Skip to content

[SPARK-10178][SQL] HiveComparisionTest should print out dependent tables #8388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[SPARK-10178][SQL] HiveComparisionTest should print out dependent tables #8388

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d717d18
Print dependent test tables
marmbrus Aug 24, 2015
4894383
fix wording
marmbrus Aug 24, 2015
125707b
better filter
marmbrus Aug 24, 2015
b3b84b4
import
marmbrus Aug 24, 2015
a723dda
address comments
marmbrus Aug 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ package org.apache.spark.sql.hive.execution

import java.io._

import scala.util.control.NonFatal

import org.scalatest.{BeforeAndAfterAll, GivenWhenThen}

import org.apache.spark.{Logging, SparkFunSuite}
Expand Down Expand Up @@ -386,11 +388,45 @@ abstract class HiveComparisonTest
hiveCacheFiles.foreach(_.delete())
}

// If this query is reading other tables that were created during this test run
// also print out the query plans and results for those.
val computedTablesMessages: String = try {
val tablesRead = new TestHive.QueryExecution(query).executedPlan.collect {
case ts: HiveTableScan => ts.relation.tableName
}.toSet

TestHive.reset()
val executions = queryList.map(new TestHive.QueryExecution(_))
executions.foreach(_.toRdd)
val tablesGenerated = queryList.zip(executions).flatMap {
case (q, e) => e.executedPlan.collect {
case i: InsertIntoHiveTable if tablesRead contains i.table.tableName =>
(q, e, i)
}
}

tablesGenerated.map { case (hiveql, execution, insert) =>
s"""
|=== Generated Table ===
|$hiveql
|$execution
|== Results ==
|${insert.child.execute().collect().mkString("\n")}
""".stripMargin
}.mkString("\n")

} catch {
case NonFatal(e) =>
logError("Failed to compute generated tables", e)
s"Couldn't compute dependent tables: $e"
}

val errorMessage =
s"""
|Results do not match for $testCaseName:
|$hiveQuery\n${hiveQuery.analyzed.output.map(_.name).mkString("\t")}
|$resultComparison
|$computedTablesMessages
""".stripMargin

stringToFile(new File(wrongDirectory, testCaseName), errorMessage + consoleTestCase)
Expand Down