[SPARK-9570][Docs][YARN]Consistent recommendation for submitting spark apps to YARN, -master yarn --deploy-mode x vs -master yarn-x' #8385
Conversation
…ifting of Master URLS
…r generic submission to help clear up confusion
…ifting of Master URLS
…r generic submission to help clear up confusion
|
Can one of the admins verify this patch? |
R/README.md
Outdated
There was a problem hiding this comment.
Since this is intended as a runnable snippet, I don't think you can write "cluster (or client)". I'd write "client". Elsewhere it's explained what this option's values are.
|
@srowen Thank you for the note. Will get it done asap. |
|
@nssalian are you working on this one? you can close the PR if you're not going to proceed with this particular change. It would be great to get something like this merged. |
|
@srowen thank you for the note. Haven't had a chance these past few weeks. |
|
Corrected the nits. Will search the whole project for other places that I have missed. |
|
That's pretty much all I could find. The rest seem to be code pointing to the option of using yarn-cluster, yarn-client and how Spark parses them. |
R/README.md
Outdated
There was a problem hiding this comment.
Here, I'd prefer showing just your new example where deploy-mode is explicit. Might as well set a good example.
|
This has a merge conflict now, sorry. It might be easier even to squash all your commits, then rebase, if you're up for it. In any event, it does just need a rebase on master and a force push. |
|
@nssalian I'd like to resolve this at last. This has outstanding comments and needs a rebase. Do you want to do that or should I take over? |
|
@srowen please go ahead. |
docs/running-on-yarn.md
Outdated
There was a problem hiding this comment.
still using yarn-cluster instead of deploy-mode
|
See #8968 now. Do you mind closing this PR? |
|
Closing in favor of #8968 |
…ps to YARN, -master yarn --deploy-mode x vs -master yarn-x'.
Recommend `--master yarn --deploy-mode {cluster,client}` consistently in docs.
Follow-on to #8385
CC nssalian
Author: Sean Owen <[email protected]>
Closes #8968 from srowen/SPARK-9570.
…ps to YARN, -master yarn --deploy-mode x vs -master yarn-x'.
Recommend `--master yarn --deploy-mode {cluster,client}` consistently in docs.
Follow-on to apache/spark#8385
CC nssalian
Author: Sean Owen <[email protected]>
Closes #8968 from srowen/SPARK-9570.
5 participants
Issue link: https://issues.apache.org/jira/browse/SPARK-9570
Previous PR: #8071
Changes made:
Requesting review.