Skip to content

Conversation

@MechCoder
Copy link
Contributor

No description provided.

@MechCoder
Copy link
Contributor Author

@mengxr @rxin

I wrote a small bash script to automate this to an extent (i.e for every file). (https://gist.github.com/MechCoder/fdc77f62050f2f698484) However it fails for some corner cases like badly formatted docs and I am not sure we would be needing this again, so I did not automate it fully and fixed the corner cases by hand.

@MechCoder MechCoder changed the title [SPARK-9864] [DOC] Replace since in scaladoc to Since annotation [SPARK-9864] [DOC] [MLlib] [SQL] Replace since in scaladoc to Since annotation Aug 21, 2015
@SparkQA
Copy link

SparkQA commented Aug 21, 2015

Test build #41362 has finished for PR 8352 at commit 576f320.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 21, 2015

Test build #41365 has finished for PR 8352 at commit 969bbbd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Aug 21, 2015

@MechCoder Could you move the changes in SQL to another PR? I think SQL is fine with @since tag. Switching to @Since will cause regression in the generated Java API doc. Let's experiment with @Since annotation in MLlib first:)

@MechCoder
Copy link
Contributor Author

rebased

@SparkQA
Copy link

SparkQA commented Aug 21, 2015

Test build #41373 has finished for PR 8352 at commit d6dbd4f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in f5b028e Aug 21, 2015
asfgit pushed a commit that referenced this pull request Aug 21, 2015
…nnotation

Author: MechCoder <[email protected]>

Closes #8352 from MechCoder/since.

(cherry picked from commit f5b028e)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented Aug 21, 2015

I checked all changes and they LGTM:) Thanks for fixing the styles too! Merged into master and branch-1.5. Could you have another PR to add Since to constructor params (if they are public)?

@MechCoder MechCoder deleted the since branch August 22, 2015 04:34
@MechCoder
Copy link
Contributor Author

thanks for the merge. I will not be available till Monday itself :( . If this is in a hurry because of the 1.5 release, please feel free to fix it yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants