[SPARK-10108] Add since tags to mllib.feature

[MechCoder]

No description provided.

[MechCoder]

@mengxr

[SparkQA]

Test build #41236 has finished for PR 8309 at commit d74ced6.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[mengxr]

@MechCoder Shall we use @Since annotation directly?

[MechCoder]

I thought we can merge all directly and replace everything at one go.

[mengxr]

No, for existing PRs, we ask the authors to stay with @since tags because most of them are first-time contributors. For new PRs, we should use @Since annotation directly.

[MechCoder]

Great. Will update in some time.

[MechCoder]

@mengxr updated.

I wrote a small bash script that would do the conversion automatically, but there is one corner case that Ihad to take care of manually

[SparkQA]

Test build #41278 has finished for PR 8309 at commit 3778da0.

• This patch fails to build.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • implicit class StringToColumn(val sc: StringContext)

[mengxr]

@MechCoder Please also check the following:

1. overridden methods that do not require JavaDoc (if the JavaDoc is the same as its parent)
2. public variables in constructors (see examples in https://issues.apache.org/jira/browse/SPARK-9864)

[mengxr]

For example, we also need to add annotation to selectedFeatures.

[MechCoder]

@mengxr I just updated the annotation for one class variable (numTopFeatures) ChiSqSelector but it does not show up in the scala doc for variables. (I have attached a screenshot)

[SparkQA]

Test build #41327 has finished for PR 8309 at commit 4abbcb3.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class ChiSqSelectorModel (
  • class ChiSqSelector (

[MechCoder]

Actually the annotations on any class variable do not show up in the doc. Can you please verify?

[mengxr]

Good catch! I will take a look.

[mengxr]

Sent a patch #8344 to fix it.

[mengxr]

Merged into master and branch-1.5. Thanks! Please make a PR that convert all existing @SInCE tags into @SInCE annotation (but do not make additional changes to simplify the code review). Then we can have another PR to fix the missing ones.

[MechCoder]

Thanks you for the patch.