[SPARK-9400][SQL]Codegen for StringLocate #8274
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #41124 has finished for PR 8274 at commit
|
Contributor
There was a problem hiding this comment.
I think we do not need these special cases for StringLocate, because you do not need any prepare to call UTF8String.indexOf(substr, start)
Member
Author
There was a problem hiding this comment.
I was following #7779 (comment), if it's not required, I think 7779 is fine.
Contributor
There was a problem hiding this comment.
Yeah, I can merge that one (fix the confict while merging).
asfgit
pushed a commit
that referenced
this pull request
Aug 20, 2015
This is based on #7779 , thanks to tarekauel . Fix the conflict and nullability. Closes #7779 and #8274 . Author: Tarek Auel <[email protected]> Author: Davies Liu <[email protected]> Closes #8330 from davies/stringLocate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the codegen for StringLocate and specialise the case when str/start is foldable.
JIRA: https://issues.apache.org/jira/browse/SPARK-9400
cc @rxin