Skip to content

Conversation

@yinxusen
Copy link
Contributor

Add user guide for VectorSlicer, with Java test suite and Python version VectorSlicer.

Note that Python version does not support selecting by names now.

@SparkQA
Copy link

SparkQA commented Aug 18, 2015

Test build #41099 has finished for PR 8267 at commit 61092cc.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class VectorSlicer(JavaTransformer, HasInputCol, HasOutputCol):

@SparkQA
Copy link

SparkQA commented Aug 18, 2015

Test build #41110 has finished for PR 8267 at commit 3ff4b5d.

  • This patch fails Python style tests.
  • This patch does not merge cleanly.
  • This patch adds the following public classes (experimental):
    • class VectorSlicer(JavaTransformer, HasInputCol, HasOutputCol):

@SparkQA
Copy link

SparkQA commented Aug 18, 2015

Test build #41113 has finished for PR 8267 at commit d5cdabd.

  • This patch fails Spark unit tests.
  • This patch does not merge cleanly.
  • This patch adds the following public classes (experimental):
    • class VectorSlicer(JavaTransformer, HasInputCol, HasOutputCol):

@feynmanliang
Copy link
Contributor

@yinxusen Sorry, I think there's some merge conflicts. Do you mind rebasing master?

@feynmanliang
Copy link
Contributor

Could you also modify the title to include java tests and python API?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know other parts of the user guides don't do this, but we should try to keep lines to 100 characters so future diffs are smaller

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: _Specification_ by integer and string are both acceptable**_. M**_oreover,

@feynmanliang
Copy link
Contributor

@yinxusen The documentation looks good. Only things left:

  • Can you update the title of the PR to include python api and java tests?
  • Do you mind resolving merge conflicts?

Thanks!

@yinxusen yinxusen changed the title [SPARK-9893] user guide for VectorSlicer [SPARK-9893] User guide with Python API and Java test suite for VectorSlicer Aug 20, 2015
@yinxusen
Copy link
Contributor Author

@feynmanliang Conflicts fixed.

@SparkQA
Copy link

SparkQA commented Aug 20, 2015

Test build #41305 has finished for PR 8267 at commit 6d066c7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class VectorSlicer(JavaTransformer, HasInputCol, HasOutputCol):

@mengxr
Copy link
Contributor

mengxr commented Aug 20, 2015

@yinxusen Could you split this PR into two? One for the user guide with example code and Java test suite, which can be merged into 1.5, and one implements the Python API. We count Python API as new features, and try not to merge them during QA.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use [] or {} as the default value in Python API, because they are mutable and shared among instances. Please use None instead. Again, we should move Python API to a separate PR.

@yinxusen yinxusen changed the title [SPARK-9893] User guide with Python API and Java test suite for VectorSlicer [SPARK-9893] User guide with Java test suite for VectorSlicer Aug 21, 2015
@SparkQA
Copy link

SparkQA commented Aug 21, 2015

Test build #41345 timed out for PR 8267 at commit f8f0d61 after a configured wait of 175m.

@feynmanliang
Copy link
Contributor

jenkins test this please

@feynmanliang
Copy link
Contributor

LGTM pending tests

@SparkQA
Copy link

SparkQA commented Aug 21, 2015

Test build #41384 has finished for PR 8267 at commit f8f0d61.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public class JavaVectorSlicerSuite

asfgit pushed a commit that referenced this pull request Aug 21, 2015
Add user guide for `VectorSlicer`, with Java test suite and Python version VectorSlicer.

Note that Python version does not support selecting by names now.

Author: Xusen Yin <[email protected]>

Closes #8267 from yinxusen/SPARK-9893.

(cherry picked from commit 630a994)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented Aug 21, 2015

Merged into master and branch-1.5. Thanks!

@asfgit asfgit closed this in 630a994 Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants