-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-9893] User guide with Java test suite for VectorSlicer #8267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #41099 has finished for PR 8267 at commit
|
|
Test build #41110 has finished for PR 8267 at commit
|
|
Test build #41113 has finished for PR 8267 at commit
|
|
@yinxusen Sorry, I think there's some merge conflicts. Do you mind rebasing master? |
|
Could you also modify the title to include java tests and python API? |
docs/ml-features.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know other parts of the user guides don't do this, but we should try to keep lines to 100 characters so future diffs are smaller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: _Specification_ by integer and string are both acceptable**_. M**_oreover,
|
@yinxusen The documentation looks good. Only things left:
Thanks! |
|
@feynmanliang Conflicts fixed. |
|
Test build #41305 has finished for PR 8267 at commit
|
|
@yinxusen Could you split this PR into two? One for the user guide with example code and Java test suite, which can be merged into 1.5, and one implements the Python API. We count Python API as new features, and try not to merge them during QA. |
python/pyspark/ml/feature.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use [] or {} as the default value in Python API, because they are mutable and shared among instances. Please use None instead. Again, we should move Python API to a separate PR.
|
Test build #41345 timed out for PR 8267 at commit |
|
jenkins test this please |
|
LGTM pending tests |
|
Test build #41384 has finished for PR 8267 at commit
|
Add user guide for `VectorSlicer`, with Java test suite and Python version VectorSlicer. Note that Python version does not support selecting by names now. Author: Xusen Yin <[email protected]> Closes #8267 from yinxusen/SPARK-9893. (cherry picked from commit 630a994) Signed-off-by: Xiangrui Meng <[email protected]>
|
Merged into master and branch-1.5. Thanks! |
Add user guide for
VectorSlicer, with Java test suite and Python version VectorSlicer.Note that Python version does not support selecting by names now.