[SPARK-7808] [ML] add package doc for ml.feature #8260
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
"most scikit-learn's" --> "most scikit-learn"
Member
|
Include link to online API doc? |
Member
|
Other than that, LGTM |
|
Test build #41078 has finished for PR 8260 at commit
|
Contributor
Author
|
We don't have a dedicated user guide section for |
|
Test build #41085 has finished for PR 8260 at commit
|
Contributor
Author
|
Merged into master and branch-1.5. |
asfgit
pushed a commit
that referenced
this pull request
Aug 18, 2015
This PR adds a short description of `ml.feature` package with code example. The Java package doc will come in a separate PR. jkbradley Author: Xiangrui Meng <[email protected]> Closes #8260 from mengxr/SPARK-7808. (cherry picked from commit e290029) Signed-off-by: Xiangrui Meng <[email protected]>
Member
|
I was suggesting the API guide, not the user guide (but we actually do have a user guide section as well: ml-feature.html) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a short description of
ml.featurepackage with code example. The Java package doc will come in a separate PR. @jkbradley