Skip to content

[SPARK-7736] [core] Fix a race introduced in PythonRunner. #8258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SPARK-7736] [core] Fix a race introduced in PythonRunner. #8258

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0df92f
[SPARK-7736] [core] Fix a race introduced in PythonRunner.
Aug 17, 2015
30b0ee5
Re-use the thread created for running the gateway.
Aug 17, 2015
cfef35d
Simpler fix.
Aug 17, 2015
d8831a2
Merge branch 'master' into SPARK-7736
Aug 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/src/main/scala/org/apache/spark/deploy/PythonRunner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,16 @@ object PythonRunner {
gatewayServer.start()
}
})
thread.setName("py4j-gateway")
thread.setName("py4j-gateway-init")
thread.setDaemon(true)
thread.start()

// Wait until the gateway server has started, so that we know which port is it bound to.
// `gatewayServer.start()` will start a new thread and run the server code there, after
// initializing the socket, so the thread started above will end as soon as the server is
// ready to serve connections.
thread.join()
Copy link
Member

@srowen srowen Aug 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was going to say, isn't there some concurrency utility for this? and you could use a task or future or semaphore, but it might not be any less code.

Copy link
Contributor Author

@vanzin vanzin Aug 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was something, but the GatewayServer API is super weird.


// Build up a PYTHONPATH that includes the Spark assembly JAR (where this class is), the
// python directories in SPARK_HOME (if set), and any files in the pyFiles argument
val pathElements = new ArrayBuffer[String]
Expand Down