[SPARK-9725] [SQL] fix serialization of UTF8String across different JVM #8210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davies
force-pushed
the
serialize_utf8string
branch
from
05b5da0 to
ebeb697
Compare
Contributor
Author
There was a problem hiding this comment.
Is there a way to still having them as final?
Contributor
There was a problem hiding this comment.
See if you can use Externalizable instead.
Contributor
Author
There was a problem hiding this comment.
Externalizable still need them to be non-final. Should we use UNSAFE here? Not sure about the performance difference about final and non-final.
|
Test build #40904 has finished for PR 8210 at commit
|
|
Test build #40913 timed out for PR 8210 at commit |
|
Test build #1611 timed out for PR 8210 at commit |
|
Test build #1613 timed out for PR 8210 at commit |
asfgit
pushed a commit
that referenced
this pull request
Aug 15, 2015
The BYTE_ARRAY_OFFSET could be different in JVM with different configurations (for example, different heap size, 24 if heap > 32G, otherwise 16), so offset of UTF8String is not portable, we should handler that during serialization. Author: Davies Liu <[email protected]> Closes #8210 from davies/serialize_utf8string. (cherry picked from commit 7c1e568) Signed-off-by: Davies Liu <[email protected]>
CodingCat
pushed a commit
to CodingCat/spark
that referenced
this pull request
Aug 17, 2015
The BYTE_ARRAY_OFFSET could be different in JVM with different configurations (for example, different heap size, 24 if heap > 32G, otherwise 16), so offset of UTF8String is not portable, we should handler that during serialization. Author: Davies Liu <[email protected]> Closes apache#8210 from davies/serialize_utf8string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BYTE_ARRAY_OFFSET could be different in JVM with different configurations (for example, different heap size, 24 if heap > 32G, otherwise 16), so offset of UTF8String is not portable, we should handler that during serialization.