[SPARK-8670][SQL] Nested columns can't be referenced in pyspark #8202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
retest this please. |
|
Test build #40879 has finished for PR 8202 at commit
|
|
Test build #40887 has finished for PR 8202 at commit
|
Contributor
There was a problem hiding this comment.
Could we still have this check if there is not '.' in item?
Contributor
There was a problem hiding this comment.
or maybe, instead of doing any checks here, is it possible to catch specific errors here thrown by the analyzer and just reformat them nicely?
Contributor
There was a problem hiding this comment.
(i assume that was the whole point of doing a check here?)
Contributor
There was a problem hiding this comment.
We already capture the AnalysisException. If it's already good enough, we can just remove this check.
Contributor
|
Thanks! Merging to master and 1.5 |
asfgit
pushed a commit
that referenced
this pull request
Aug 14, 2015
This bug is caused by a wrong column-exist-check in `__getitem__` of pyspark dataframe. `DataFrame.apply` accepts not only top level column names, but also nested column name like `a.b`, so we should remove that check from `__getitem__`. Author: Wenchen Fan <[email protected]> Closes #8202 from cloud-fan/nested.
CodingCat
pushed a commit
to CodingCat/spark
that referenced
this pull request
Aug 17, 2015
This bug is caused by a wrong column-exist-check in `__getitem__` of pyspark dataframe. `DataFrame.apply` accepts not only top level column names, but also nested column name like `a.b`, so we should remove that check from `__getitem__`. Author: Wenchen Fan <[email protected]> Closes apache#8202 from cloud-fan/nested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is caused by a wrong column-exist-check in
__getitem__of pyspark dataframe.DataFrame.applyaccepts not only top level column names, but also nested column name likea.b, so we should remove that check from__getitem__.