-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-9679][ML][PYSPARK] Add Python API for Stop Words Remover #8118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-9679][ML][PYSPARK] Add Python API for Stop Words Remover #8118
Conversation
|
jenkins, retest this please. |
|
Test build #40679 has finished for PR 8118 at commit
|
|
jenkins, retest this please |
|
jenkins, retest this please. |
|
Test build #40830 has finished for PR 8118 at commit
|
|
Test build #41169 has finished for PR 8118 at commit
|
python/pyspark/ml/feature.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why this __init__ doc string breaks the pattern of just repeating the method with default args seen elsewhere in feature.py?
|
Test build #41654 has finished for PR 8118 at commit
|
python/pyspark/ml/feature.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these prints intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh no, I was checking the type when debugging something
|
some small comments, LGTM after they're fixed |
|
Test build #41672 has finished for PR 8118 at commit
|
|
jenkins, retest this please. |
|
Test build #41679 has finished for PR 8118 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private[spark] should be the same but appears more often
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: Since the object is already StopWords, would English be sufficient? We didn't use ENGLISH_STOP_WORDS because it is a mutable array.
|
Test build #41761 has finished for PR 8118 at commit
|
|
Test build #41764 has finished for PR 8118 at commit
|
|
LGTM except a minor issue on the test code style. |
|
Test build #41848 has finished for PR 8118 at commit
|
|
Merged into master. Thanks! |
Add a python API for the Stop Words Remover.