Skip to content

Conversation

@holdenk
Copy link
Contributor

@holdenk holdenk commented Aug 12, 2015

Add a python API for the Stop Words Remover.

@holdenk
Copy link
Contributor Author

holdenk commented Aug 12, 2015

jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 12, 2015

Test build #40679 has finished for PR 8118 at commit ec6baab.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • * Set thresholds in multiclass (or binary) classification to adjust the probability of
    • class StopWordsRemover(JavaTransformer, HasInputCol, HasOutputCol):

@holdenk
Copy link
Contributor Author

holdenk commented Aug 13, 2015

jenkins, retest this please

@holdenk
Copy link
Contributor Author

holdenk commented Aug 13, 2015

jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 14, 2015

Test build #40830 has finished for PR 8118 at commit b98bb1d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 18, 2015

Test build #41169 has finished for PR 8118 at commit d8e3672.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this __init__ doc string breaks the pattern of just repeating the method with default args seen elsewhere in feature.py?

@SparkQA
Copy link

SparkQA commented Aug 26, 2015

Test build #41654 has finished for PR 8118 at commit 84bc507.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StopWordsRemover(JavaTransformer, HasInputCol, HasOutputCol):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these prints intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no, I was checking the type when debugging something

@feynmanliang
Copy link
Contributor

some small comments, LGTM after they're fixed

@SparkQA
Copy link

SparkQA commented Aug 27, 2015

Test build #41672 has finished for PR 8118 at commit acfc9fe.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StopWordsRemover(JavaTransformer, HasInputCol, HasOutputCol):

@holdenk
Copy link
Contributor Author

holdenk commented Aug 27, 2015

jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 27, 2015

Test build #41679 has finished for PR 8118 at commit 53f97b7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StopWordsRemover(JavaTransformer, HasInputCol, HasOutputCol):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private[spark] should be the same but appears more often

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Since the object is already StopWords, would English be sufficient? We didn't use ENGLISH_STOP_WORDS because it is a mutable array.

@SparkQA
Copy link

SparkQA commented Aug 28, 2015

Test build #41761 has finished for PR 8118 at commit 7767df0.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StopWordsRemover(JavaTransformer, HasInputCol, HasOutputCol):

@SparkQA
Copy link

SparkQA commented Aug 28, 2015

Test build #41764 has finished for PR 8118 at commit 345bde2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StopWordsRemover(JavaTransformer, HasInputCol, HasOutputCol):

@mengxr
Copy link
Contributor

mengxr commented Aug 31, 2015

LGTM except a minor issue on the test code style.

@SparkQA
Copy link

SparkQA commented Sep 1, 2015

Test build #41848 has finished for PR 8118 at commit 62b821a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class DCT(JavaTransformer, HasInputCol, HasOutputCol):
    • class SQLTransformer(JavaTransformer):
    • class StopWordsRemover(JavaTransformer, HasInputCol, HasOutputCol):

@asfgit asfgit closed this in e6e483c Sep 1, 2015
@mengxr
Copy link
Contributor

mengxr commented Sep 1, 2015

Merged into master. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants