Skip to content

Conversation

@HyukjinKwon
Copy link
Member

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'd be better if we expand this a bit to explain what null-safe means. e.g. similar to what's in mysql docs: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator%5Fequal-to

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I write like this?

A filter that evaluates to true if the attribute evaluates to a value equal to value and if both the attribute and the value are null.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this

Performs equality comparison, similar to [[EqualTo]]. However, this differs from [[EqualTo]] in that it returns true (rather than NULL) if both inputs are NULL, and false (rather than NULL) if one of the input is NULL and the other is not NULL.

@rxin
Copy link
Contributor

rxin commented Aug 11, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Aug 11, 2015

Test build #40428 has finished for PR 8096 at commit 7cdcf1c.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class EqualNullSafe(attribute: String, value: Any) extends Filter

@HyukjinKwon
Copy link
Member Author

Reset this please :)

@rxin
Copy link
Contributor

rxin commented Aug 11, 2015

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 11, 2015

Test build #40481 has finished for PR 8096 at commit b3fe5d3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class EqualNullSafe(attribute: String, value: Any) extends Filter

@rxin
Copy link
Contributor

rxin commented Aug 11, 2015

Thanks - I've merged this.

asfgit pushed a commit that referenced this pull request Aug 11, 2015
Author: hyukjinkwon <[email protected]>
Author: 권혁진 <[email protected]>

Closes #8096 from HyukjinKwon/master.

(cherry picked from commit 00c0272)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 00c0272 Aug 11, 2015
CodingCat pushed a commit to CodingCat/spark that referenced this pull request Aug 17, 2015
Author: hyukjinkwon <[email protected]>
Author: 권혁진 <[email protected]>

Closes apache#8096 from HyukjinKwon/master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants