Skip to content

Conversation

@BertrandDechoux
Copy link
Contributor

A minor typo (centriod -> centroid). Readable variable names help every users.

@jkbradley
Copy link
Member

ok to test

@jkbradley
Copy link
Member

LGTM pending tests.
@BertrandDechoux Could you please create a JIRA and link the JIRA number in the title? We're trying to do that even for small PRs.

@BertrandDechoux
Copy link
Contributor Author

Sure. The documentation should be updated then.

https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark

However, trivial changes, where the what should change is virtually the same as the how it should change do not require a JIRA. Example: "Fix typos in Foo scaladoc"

@BertrandDechoux BertrandDechoux changed the title centriod typo [SPARK-9748] [MLlib] Centriod typo in KMeansModel Aug 7, 2015
@srowen
Copy link
Member

srowen commented Aug 7, 2015

Yeah, this seems below the level of a JIRA to me. Describing it is almost the same as fixing it. I am not sure we're trying to make every single change a JIRA. In any event it's easier to just make a JIRA than debate it in this instance.

@mengxr
Copy link
Contributor

mengxr commented Aug 7, 2015

Agree with @srowen . It should be okay to mark this PR title as [MINOR].

@jkbradley
Copy link
Member

Oh OK I thought we were discouraging the use of minor, but that's fine with me

@SparkQA
Copy link

SparkQA commented Aug 7, 2015

Test build #1406 has finished for PR 8037 at commit 47632fe.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

Merging with master. Thanks!

@asfgit asfgit closed this in 902334f Aug 7, 2015
@BertrandDechoux BertrandDechoux deleted the kmeans-typo branch August 14, 2015 09:48
CodingCat pushed a commit to CodingCat/spark that referenced this pull request Aug 17, 2015
A minor typo (centriod -> centroid). Readable variable names help every users.

Author: Bertrand Dechoux <[email protected]>

Closes apache#8037 from BertrandDechoux/kmeans-typo and squashes the following commits:

47632fe [Bertrand Dechoux] centriod typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants