Skip to content

Conversation

@yjshen
Copy link
Member

@yjshen yjshen commented Jul 31, 2015

This PR is based on the original work by @JoshRosen in #7780, which adds ScalaCheck property-based tests for UTF8String.

@yjshen
Copy link
Member Author

yjshen commented Jul 31, 2015

cc @JoshRosen @rxin @chenghao-intel

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's used to compare levenshteinDistance between UTF8String and StringUtils

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39226 has finished for PR 7830 at commit c0800e6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Aug 1, 2015

cc @davies for review

@davies
Copy link
Contributor

davies commented Aug 1, 2015

lgtm, only one comment

@yjshen
Copy link
Member Author

yjshen commented Aug 1, 2015

Thanks, I will update the code now.

@SparkQA
Copy link

SparkQA commented Aug 1, 2015

Test build #39313 has finished for PR 7830 at commit 593da3a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 14f2634 Aug 1, 2015
asfgit pushed a commit that referenced this pull request Aug 17, 2015
…in sql expressions

JIRA: https://issues.apache.org/jira/browse/SPARK-9526

This PR is a follow up of #7830, aiming at utilizing randomized tests to reveal more potential bugs in sql expression.

Author: Yijie Shen <[email protected]>

Closes #7855 from yjshen/property_check.

(cherry picked from commit b265e28)
Signed-off-by: Josh Rosen <[email protected]>
asfgit pushed a commit that referenced this pull request Aug 17, 2015
…in sql expressions

JIRA: https://issues.apache.org/jira/browse/SPARK-9526

This PR is a follow up of #7830, aiming at utilizing randomized tests to reveal more potential bugs in sql expression.

Author: Yijie Shen <[email protected]>

Closes #7855 from yjshen/property_check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants