Skip to content

Conversation

@hhbyyh
Copy link
Contributor

@hhbyyh hhbyyh commented Jul 31, 2015

jira: https://issues.apache.org/jira/browse/SPARK-7583

User guide update for RegexTokenizer

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39213 has finished for PR 7828 at commit f6eb1dd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chop down setters:

val regexTokenizer = new RegexTokenizer()
  .setInputCol("sentence")
  .setOutputCol("words")
  .setPattern("\\W")

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Aug 12, 2015

Thanks for the review. I've sent an update addressing the comments.

@SparkQA
Copy link

SparkQA commented Aug 12, 2015

Test build #40616 has finished for PR 7828 at commit 4970d78.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Aug 12, 2015
jira: https://issues.apache.org/jira/browse/SPARK-7583

User guide update for RegexTokenizer

Author: Yuhao Yang <[email protected]>

Closes #7828 from hhbyyh/regexTokenizerDoc.

(cherry picked from commit 66d87c1)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented Aug 12, 2015

LGTM. Merged into master and branch-1.5. Thanks!

@asfgit asfgit closed this in 66d87c1 Aug 12, 2015
CodingCat pushed a commit to CodingCat/spark that referenced this pull request Aug 17, 2015
jira: https://issues.apache.org/jira/browse/SPARK-7583

User guide update for RegexTokenizer

Author: Yuhao Yang <[email protected]>

Closes apache#7828 from hhbyyh/regexTokenizerDoc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants