[SPARK-8176] [SPARK-8197] [SQL] function to_date/ trunc #7805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
mistake, will rollback.
|
Test build #39106 has finished for PR 7805 at commit
|
davies
force-pushed
the
to_date
branch
2 times, most recently
from
b4dce35 to
2eae516
Compare
Conflicts: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala sql/core/src/main/scala/org/apache/spark/sql/functions.scala sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala
|
Test build #1244 has finished for PR 7805 at commit
|
|
Test build #1245 has finished for PR 7805 at commit
|
|
Test build #39108 has finished for PR 7805 at commit
|
Contributor
Author
|
ping @rxin |
Contributor
There was a problem hiding this comment.
tiny optimization - this can just call child.genCode
Contributor
Author
There was a problem hiding this comment.
genCode is protected.
Contributor
|
LGTM at the implementation. Just some minor comments. I'm going to merge this. Can you address these comments in your next pr on expressions? |
davies
pushed a commit
to davies/spark
that referenced
this pull request
Jul 31, 2015
asfgit
pushed a commit
that referenced
this pull request
Jul 31, 2015
This PR address the comments in #7805 cc rxin Author: Davies Liu <[email protected]> Closes #7817 from davies/trunc and squashes the following commits: f729d5f [Davies Liu] rollback cb7f783 [Davies Liu] genCode() is protected 31e52ef [Davies Liu] fix style ed1edc7 [Davies Liu] address comments for #7805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #6988 , thanks to @adrian-wang .
This brings two SQL functions: to_date() and trunc().
Closes #6988