Skip to content

[SPARK-9460] Fix prefix generation for UTF8String. #7789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[SPARK-9460] Fix prefix generation for UTF8String. #7789

wants to merge 3 commits into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Jul 30, 2015

Previously we could be getting garbage data if the number of bytes is 0, or on JVMs that are 4 byte aligned, or when compressedoops is on.

@rxin
Copy link
Contributor Author

rxin commented Jul 30, 2015

cc @davies and @tellison

@rednaxelafx
Copy link
Contributor

rednaxelafx commented Jul 30, 2015

Yes, this change looks good to me, for a "semantically safe bet" on the object layout.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39027 has finished for PR 7789 at commit 7541a81.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

davies
davies reviewed Jul 30, 2015
View reviewed changes
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java Outdated
Copy link
Contributor

@davies davies Jul 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check the endian-ness? I think UNSAFE.getLong use the native endian.

rxin
rxin reviewed Jul 30, 2015
View reviewed changes
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
Copy link
Contributor Author

@rxin rxin Jul 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this currently won't work for big endian. can somebody from ibm submit a patch to make it work? I don't have the environment to test.

Copy link
Contributor

@davies davies Jul 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just merge this one, add a comment and create a JIRA for big-endian.

Copy link
Contributor Author

@rxin rxin Jul 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup that's a good idea.

Copy link
Contributor Author

@rxin rxin Jul 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the ticket https://issues.apache.org/jira/browse/SPARK-9483

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39077 has finished for PR 7789 at commit 86ffa3e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Jul 30, 2015

Merging this since the failed test is unrelated.

@asfgit asfgit closed this in a20e743 Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rxin @rednaxelafx @SparkQA @davies