Skip to content

Conversation

@XiaoqingWang
Copy link

No description provided.

@mengxr
Copy link
Contributor

mengxr commented Jul 29, 2015

ok to test

@mengxr
Copy link
Contributor

mengxr commented Jul 29, 2015

@yu-iskw Could you help review this PR? Thanks!

@SparkQA
Copy link

SparkQA commented Jul 29, 2015

Test build #38821 has finished for PR 7662 at commit d8729a3.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yu-iskw
Copy link
Contributor

yu-iskw commented Jul 29, 2015

Alright. I'll check this PR later.

@yu-iskw
Copy link
Contributor

yu-iskw commented Aug 7, 2015

@XiaoqingWang thank you for the contribution! And sorry for the delay of my response. It seems that you added the annotations based on branch-1.4. However, such a GaussianMixtureModel.predict(point: Vector) method doesn't exist on the mater branch. I have no idea why SPARK-8481 wasn't merged into the mater branch. I am asking that to @jkbradley at #6906.

Apart from that, it seems that you try to merge this PR into branch-1.4. According to JIRA, the target version SPARK-8918 is 1.5.0. I think you should implement this PR based on the master branch and send a PR to the master branch.

Could you close this PR and then resend a new one to change the target branch. Since we can't change the target branch after sending a PR. And you should add annotations based on the master branch. Thanks!

@mengxr
Copy link
Contributor

mengxr commented Aug 11, 2015

@XiaoqingWang Could you send a new PR to the master branch as @yu-iskw suggested? We should get this merged before the 1.5 RC release.

@jkbradley
Copy link
Member

Pinging for updates (Thanks!)

@mengxr
Copy link
Contributor

mengxr commented Aug 14, 2015

I'm taking this PR over. Thanks @XiaoqingWang for making the initial pass!

@XiaoqingWang
Copy link
Author

a new pull request (#8229) for this has been submited,I am sorry for the delay,please help to review ,thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants