[SPARK-9306][SQL] Don't use SortMergeJoin when joining on unsortable columns #7645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
I find the double-negation here to be a bit confusing. Could we remove a level of negation by using forall instead of exists and pushing the negation down?
Member
Author
There was a problem hiding this comment.
Thanks. Updated to make it more readable.
Contributor
|
Thanks for fixing this! I'm going to try out your patch on top of #7625, the fuzz testing tool that I used to find this bug. |
Contributor
|
Jenkins, retest this please. |
|
Test build #38369 has finished for PR 7645 at commit
|
Contributor
|
LGTM. |
Contributor
|
LGTM |
Contributor
|
Jenkins, retest this please. |
|
Test build #38480 has finished for PR 7645 at commit
|
Contributor
|
I'm going to merge this into master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/SPARK-9306