Skip to content

[SPARK-9295] Analysis should detect sorting on unsupported column types #7633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[SPARK-9295] Analysis should detect sorting on unsupported column types #7633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f1b802
Add analysis rule to detect sorting on unsupported column types (SPAR…
JoshRosen Jul 24, 2015
bfe1451
Update to allow sorting by null literals
JoshRosen Jul 24, 2015
23b2fbf
Embed function in foreach
JoshRosen Jul 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,16 @@ trait CheckAnalysis {

aggregateExprs.foreach(checkValidAggregateExpression)

case Sort(orders, _, _) =>
orders.foreach { order =>
order.dataType match {
case t: AtomicType => // OK
case NullType => // OK
case t =>
failAnalysis(s"Sorting is not supported for columns of type ${t.simpleString}")
}
}

case _ => // Fallbacks to the following checks
}

Expand Down
5 changes: 5 additions & 0 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ class AnalysisErrorSuite extends SparkFunSuite with BeforeAndAfter {
testRelation.select(Literal(1).cast(BinaryType).as('badCast)),
"cannot cast" :: Literal(1).dataType.simpleString :: BinaryType.simpleString :: Nil)

errorTest(
"sorting by unsupported column types",
listRelation.orderBy('list.asc),
"sorting" :: "type" :: "array<int>" :: Nil)

errorTest(
"non-boolean filters",
testRelation.where(Literal(1)),
Expand Down