SPARK-1623: Use File objects instead of String's in HTTPBroadcast #749
Conversation
This seems strictly better, and I think it's justified only the grounds of clean-up. It might also fix issues with path conversions, but I haven't yet isolated any instance of that happening.
pwendell
changed the title
|
Merged build triggered. |
|
Merged build started. |
|
This looks better just from the fact that it isn't relying on toString(); it probably doesn't change the functionality, though, since from the rest of the code in that file, it seems all these files are being created with absolute paths. |
|
Agree, if the paths were all absolute to begin with, this is a more robust way of doing the same thing. I don't know if they were all absolute in fact (in which case the original code wouldn't quite work); it is a good bet. Either way +1 |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
Okay cool, this is just a minor improvement. |
This seems strictly better, and I think it's justified only the grounds of clean-up. It might also fix issues with path conversions, but I haven't yet isolated any instance of that happening. /cc @srowen @tdas Author: Patrick Wendell <[email protected]> Closes #749 from pwendell/broadcast-cleanup and squashes the following commits: d6d54f2 [Patrick Wendell] SPARK-1623: Use File objects instead of string's in HTTPBroadcast (cherry picked from commit 925d8b2) Signed-off-by: Patrick Wendell <[email protected]>
This seems strictly better, and I think it's justified only the grounds of clean-up. It might also fix issues with path conversions, but I haven't yet isolated any instance of that happening. /cc @srowen @tdas Author: Patrick Wendell <[email protected]> Closes apache#749 from pwendell/broadcast-cleanup and squashes the following commits: d6d54f2 [Patrick Wendell] SPARK-1623: Use File objects instead of string's in HTTPBroadcast
4 participants
This seems strictly better, and I think it's justified only the grounds of
clean-up. It might also fix issues with path conversions, but I haven't
yet isolated any instance of that happening.
/cc @srowen @tdas