Skip to content

[SPARK-1736] Spark submit for Windows #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[SPARK-1736] Spark submit for Windows #745

wants to merge 4 commits into from

Conversation

@andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented May 12, 2014

Tested on Windows 7.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2014

Merged build started.

pwendell
pwendell reviewed May 12, 2014
View reviewed changes
bin/spark-submit.cmd Outdated
Copy link
Contributor

@pwendell pwendell May 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure this works with quoted strings. E.g. spark-submit --name "this is a cool app"

Copy link
Contributor Author

@andrewor14 andrewor14 May 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing code on this line already takes care of that. It just breaks when we do a string check for emptiness before. The latest commit fixes this.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 12, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14909/

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2014

Merged build started.

@asfgit asfgit closed this in beb9cba May 13, 2014
asfgit pushed a commit that referenced this pull request May 13, 2014
@andrewor14 @pwendell
[SPARK-1736] Spark submit for Windows
59695b3 
Tested on Windows 7.

Author: Andrew Or <[email protected]>

Closes #745 from andrewor14/windows-submit and squashes the following commits:

c0b58fb [Andrew Or] Allow spaces in parameters
162e54d [Andrew Or] Merge branch 'master' of github.com:apache/spark into windows-submit
91597ce [Andrew Or] Make spark-shell.cmd use spark-submit.cmd
af6fd29 [Andrew Or] Add spark submit for Windows
@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2014

Merged build finished. All automated tests passed.

1 similar comment
@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14916/

@AmplabJenkins
Copy link

AmplabJenkins commented May 13, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14914/

@andrewor14 andrewor14 deleted the windows-submit branch May 13, 2014 01:23
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@andrewor14 @pdeyhim
[SPARK-1736] Spark submit for Windows
28d7af3 
Tested on Windows 7.

Author: Andrew Or <[email protected]>

Closes apache#745 from andrewor14/windows-submit and squashes the following commits:

c0b58fb [Andrew Or] Allow spaces in parameters
162e54d [Andrew Or] Merge branch 'master' of github.com:apache/spark into windows-submit
91597ce [Andrew Or] Make spark-shell.cmd use spark-submit.cmd
af6fd29 [Andrew Or] Add spark submit for Windows
turboFei added a commit to turboFei/spark that referenced this pull request Nov 6, 2025
@turboFei
[ADLC] Add hadoop compute DL (apache#745)
50fa293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewor14 @AmplabJenkins @pwendell