Skip to content

Conversation

@liancheng
Copy link
Contributor

This PR adds DataFrame reader/writer shortcut methods for ORC in both Scala and Python.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Also add examples like you did at DataFrameWriter?

  • This is equivalent to:
  • {{{
  • format("orc").load(path)
  • }}}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one in DataFrameWriter isn't an example, it says that method is equivalent to format("orc").load(path).

@SparkQA
Copy link

SparkQA commented Jul 16, 2015

Test build #37497 has finished for PR 7444 at commit e0b09fb.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should document this is only available if hive is ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, right. Thanks for reminding!

@liancheng
Copy link
Contributor Author

@rxin @davies A little off topic, but python/pyspark/sql/readwriter.py should probably be renamed to readerwriter.py or readwrite.py. Which do you prefer?

@SparkQA
Copy link

SparkQA commented Jul 17, 2015

Test build #37616 has finished for PR 7444 at commit 284d043.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Jul 17, 2015

Test build #37640 has finished for PR 7444 at commit 284d043.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jul 21, 2015

lgtm

@liancheng
Copy link
Contributor Author

Thanks for the review, merging to master.

@asfgit asfgit closed this in d38c502 Jul 21, 2015
@liancheng liancheng deleted the spark-9100 branch July 21, 2015 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants