-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-9100] [SQL] Adds DataFrame reader/writer shortcut methods for ORC #7444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Also add examples like you did at DataFrameWriter?
- This is equivalent to:
- {{{
- format("orc").load(path)
- }}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one in DataFrameWriter isn't an example, it says that method is equivalent to format("orc").load(path).
|
Test build #37497 has finished for PR 7444 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should document this is only available if hive is ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, right. Thanks for reminding!
|
Test build #37616 has finished for PR 7444 at commit
|
|
retest this please |
|
Test build #37640 has finished for PR 7444 at commit
|
|
lgtm |
|
Thanks for the review, merging to master. |
This PR adds DataFrame reader/writer shortcut methods for ORC in both Scala and Python.