-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-9018][MLLIB] add stopwatches #7415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #37329 has finished for PR 7415 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space!
|
That's all I see. But also note Sean's comments in the JIRA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
triple equals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually @ericl pointed out == and === are equal in this case (Long). Both provide the same error message. I will update it to be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we no longer bother with this? Or is it just for Longs (in which case enforcing consistency may be easiest)?
|
LGTM pending tests |
|
Test build #37400 has finished for PR 7415 at commit
|
|
I'll let you fix that, or merge, as you like |
|
Test build #37449 has finished for PR 7415 at commit
|
|
Merged into master. |
Add stopwatches for easy instrumentation of MLlib algorithms. This is based on the
TimeTrackerused in decision trees. The distributed version uses Spark accumulator. @jkbradley