Skip to content

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Jul 15, 2015

Add stopwatches for easy instrumentation of MLlib algorithms. This is based on the TimeTracker used in decision trees. The distributed version uses Spark accumulator. @jkbradley

@SparkQA
Copy link

SparkQA commented Jul 15, 2015

Test build #37329 has finished for PR 7415 at commit f981a49.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space!

@jkbradley
Copy link
Member

That's all I see. But also note Sean's comments in the JIRA.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triple equals

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually @ericl pointed out == and === are equal in this case (Long). Both provide the same error message. I will update it to be consistent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we no longer bother with this? Or is it just for Longs (in which case enforcing consistency may be easiest)?

@jkbradley
Copy link
Member

LGTM pending tests

@SparkQA
Copy link

SparkQA commented Jul 15, 2015

Test build #37400 has finished for PR 7415 at commit c477745.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

I'll let you fix that, or merge, as you like

@SparkQA
Copy link

SparkQA commented Jul 16, 2015

Test build #37449 has finished for PR 7415 at commit 40b4347.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor Author

mengxr commented Jul 16, 2015

Merged into master.

@asfgit asfgit closed this in 73d92b0 Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants