Skip to content

Conversation

@sun-rui
Copy link
Contributor

@sun-rui sun-rui commented Jul 14, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Jul 14, 2015

Test build #37222 has finished for PR 7395 at commit 88590b1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yu-iskw
Copy link
Contributor

yu-iskw commented Jul 14, 2015

@sun-rui great work! Could you show us the result of lint-r?

@shivaram
Copy link
Contributor

Thanks @sun-rui LGTM.

@shivaram
Copy link
Contributor

@sun-rui -- I just ran dev/lint-r and it looks like there are a few more places where we need to fix assignment. Pasting the list below

cat dev/lint-r-report.log | grep "assignment" -A 1
inst/tests/test_binary_function.R:79:12: style: Use <-, not =, for assignment.
  mockFile = c("Spark is pretty.", "Spark is awesome.")
--
inst/tests/test_binaryFile.R:23:10: style: Use <-, not =, for assignment.
mockFile = c("Spark is pretty.", "Spark is awesome.")
--
inst/tests/test_rdd.R:450:12: style: Use <-, not =, for assignment.
  mockFile = c("Spark is pretty.", "Spark is awesome.")
--
inst/tests/test_rdd.R:486:12: style: Use <-, not =, for assignment.
  mockFile = c("Spark is pretty.", "Spark is awesome.")
--
inst/tests/test_textFile.R:23:10: style: Use <-, not =, for assignment.
mockFile = c("Spark is pretty.", "Spark is awesome.")
--
inst/tests/test_utils.R:122:5: style: Use <-, not =, for assignment.
  t = 4  # Override base::t in .GlobalEnv.
--
R/client.R:39:24: style: Use <-, not =, for assignment.
    sparkSubmitBinName = "spark-submit"
--
R/client.R:41:24: style: Use <-, not =, for assignment.
    sparkSubmitBinName = "spark-submit.cmd"
--
R/DataFrame.R:1331:35: style: Use <-, not =, for assignment.
                options[['path']] = path
--
R/group.R:90:18: style: Use <-, not =, for assignment.
            cols = list(...)
--
R/group.R:100:31: style: Use <-, not =, for assignment.
                    cols[[n]] = alias(cols[[n]], n)
--
R/utils.R:44:26: style: Use <-, not =, for assignment.
                keyBytes = callJMethod(obj, "_1")
--
R/utils.R:45:26: style: Use <-, not =, for assignment.
                valBytes = callJMethod(obj, "_2")

@sun-rui
Copy link
Contributor Author

sun-rui commented Jul 15, 2015

OK. I will clean them together

@sun-rui
Copy link
Contributor Author

sun-rui commented Jul 15, 2015

All reported issues of such kind are cleaned.

@SparkQA
Copy link

SparkQA commented Jul 15, 2015

Test build #37310 has finished for PR 7395 at commit ce603bc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

LGTM. Merging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants