-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-8774] [ML] Add R model formula with basic support as a transformer #7381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #37166 has finished for PR 7381 at commit
|
|
Test build #37170 has finished for PR 7381 at commit
|
|
Test build #37167 has finished for PR 7381 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also mention the operators we support and a link to the official R formula document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
Test build #37282 has finished for PR 7381 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use http://stat.ethz.ch/R-manual/R-patched/library/stats/html/formula.html instead, which is in the raw R manual format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unused imports
|
@ericl I make another pass. The major issue is actually that |
|
@mengxr That makes sense, I'll do that in a followup PR. I also addressed the comments. |
|
Test build #37425 has finished for PR 7381 at commit
|
|
Test build #37426 has finished for PR 7381 at commit
|
|
LGTM except some minor comments, which we can fix in the next PR. Merged into master. Thanks! As the next step, we can create a wrapper for |
|
Sounds good, I'll look at the R integration next. |
This implements minimal R formula support as a feature transformer. Both numeric and string labels are supported, but features must be numeric for now.
cc @mengxr