Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Jul 13, 2015

Add predictProbabilities to Naive Bayes, return class probabilities.

Continues #6761

@SparkQA
Copy link

SparkQA commented Jul 13, 2015

Test build #37148 has finished for PR 7376 at commit b32d1c8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

Jenkins, slow test please

@SparkQA
Copy link

SparkQA commented Jul 13, 2015

Test build #1 has finished for PR 7376 at commit b32d1c8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@acidghost
Copy link

Looks good to me. There's no check that they sum to 1 or that the prediction from probabilities is right, but I don't think is necessary

@srowen
Copy link
Member Author

srowen commented Jul 14, 2015

The prediction is already checked in the existing tests. I can add a check for sum to 1 though, yes.

@SparkQA
Copy link

SparkQA commented Jul 14, 2015

Test build #37214 has finished for PR 7376 at commit 95d91fb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

I'll take a look

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"labels" --> "theta"

@jkbradley
Copy link
Member

That one item doesn't really matter; LGTM if you want to merge.
Thanks!

@SparkQA
Copy link

SparkQA commented Jul 14, 2015

Test build #37264 has finished for PR 7376 at commit 23d5a76.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 740b034 Jul 14, 2015
@srowen srowen deleted the SPARK-4362 branch July 14, 2015 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants