-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-4362] [MLLIB] Make prediction probability available in NaiveBayesModel #7376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #37148 has finished for PR 7376 at commit
|
|
Jenkins, slow test please |
|
Test build #1 has finished for PR 7376 at commit
|
|
Looks good to me. There's no check that they sum to 1 or that the prediction from probabilities is right, but I don't think is necessary |
|
The prediction is already checked in the existing tests. I can add a check for sum to 1 though, yes. |
|
Test build #37214 has finished for PR 7376 at commit
|
|
I'll take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"labels" --> "theta"
|
That one item doesn't really matter; LGTM if you want to merge. |
|
Test build #37264 has finished for PR 7376 at commit
|
Add predictProbabilities to Naive Bayes, return class probabilities.
Continues #6761