[SPARK-8895] MetricsSystem.removeSource should be called in StreamingContext.stop #7317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Context.stop This ensures that if one StreamingContext is created after stopping another using the same SparkContext, MetricRegistry does not complain that the metrics are already registered.
|
Can one of the admins verify this patch? |
Contributor
|
@aniketbhatnagar There is already a PR for this. #7250 |
Member
|
Do you mind closing this PR? |
Contributor
Author
|
Closed in favour of Duplicate #7250 |
aniketbhatnagar
deleted the
SPARK-8895-Streaming-MetricsSystem-removeSource
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if one StreamingContext is created after stopping
another using the same SparkContext, MetricRegistry does not complain
that the metrics are already registered.