Skip to content

[SPARK-8909][Documentation] Nice to have all the examples in scala, java,python, R to be same in sql-programming-guide #7299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-8909][Documentation] Nice to have all the examples in scala, java,python, R to be same in sql-programming-guide #7299

wants to merge 2 commits into from

Conversation

@aloknsingh
Copy link

@aloknsingh aloknsingh commented Jul 8, 2015

…ng-guide#Manually Specifying Options to be in sync with java,python, R version

[SPARK-8909][Documentation] Change the scala example in sql-programmi…
d476140 
…ng-guide#Manually Specifying Options to be in sync with java,python, R version
@AmplabJenkins
Copy link

AmplabJenkins commented Jul 8, 2015

Can one of the admins verify this patch?

andrewor14
andrewor14 reviewed Jul 8, 2015
View reviewed changes
docs/sql-programming-guide.md Outdated
Copy link
Contributor

@andrewor14 andrewor14 Jul 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the extension still says .json. Do we need to change that too?

Copy link
Author

@aloknsingh aloknsingh Jul 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree @andrewor14 . thanks for this :)

@sarutak
Copy link
Member

sarutak commented Jul 8, 2015

ok to test.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 8, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 8, 2015

Merged build started.

@sarutak
Copy link
Member

sarutak commented Jul 8, 2015

@aloknsingh Could you set more proper title like the corresponding issue in JIRA?

@SparkQA
Copy link

SparkQA commented Jul 8, 2015

Test build #36839 has started for PR 7299 at commit d3c20ba.

@aloknsingh
Copy link
Author

aloknsingh commented Jul 8, 2015

@sarutak . Thanks for the comments. I have changed it to "Nice to have all the examples in scala, java,python, R to be same in sql-programming-guide" . Please feel free to change the title as you see right.

@sarutak
Copy link
Member

sarutak commented Jul 8, 2015

@aloknsingh Sorry I mean we should have more proper title of this PR, not in JIRA. Do you mind changing it? We can't change the title of PRs which someone created.

@SparkQA
Copy link

SparkQA commented Jul 8, 2015

Test build #36839 has finished for PR 7299 at commit d3c20ba.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 8, 2015

Merged build finished. Test PASSed.

@rxin
Copy link
Contributor

rxin commented Jul 8, 2015

Thanks - I've merged this.

@asfgit asfgit closed this in 8f3cd93 Jul 8, 2015
asfgit pushed a commit that referenced this pull request Jul 8, 2015
@rxin
[SPARK-8909][Documentation] Change the scala example in sql-programmi…
4df0f1b 
…ng-guide#Manually Specifying Options to be in sync with java,python, R version

Author: Alok Singh <“[email protected]”>

Closes #7299 from aloknsingh/aloknsingh_SPARK-8909 and squashes the following commits:

d3c20ba [Alok Singh] fix the file to .parquet from .json
d476140 [Alok Singh] [SPARK-8909][Documentation] Change the scala example in sql-programming-guide#Manually Specifying Options to be in sync with java,python, R version

(cherry picked from commit 8f3cd93)
Signed-off-by: Reynold Xin <[email protected]>
@aloknsingh aloknsingh changed the title [SPARK-8909][Documentation] Change the scala example in sql-programmi… [SPARK-8909][Documentation] Nice to have all the examples in scala, java,python, R to be same in sql-programming-guide Jul 8, 2015
@aloknsingh
Copy link
Author

aloknsingh commented Jul 8, 2015

@sarutak I have changed it as per your comments

@sarutak
Copy link
Member

sarutak commented Jul 8, 2015

@aloknsingh Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aloknsingh @AmplabJenkins @sarutak @SparkQA @rxin @andrewor14