Skip to content

Conversation

@SaintBacchus
Copy link
Contributor

Add a configuration to set checkpoint directory for convenience to user.
Jira Address

@SparkQA
Copy link

SparkQA commented Jul 4, 2015

Test build #36521 has finished for PR 7218 at commit dd0acc1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class ShiftRightUnsigned(left: Expression, right: Expression) extends BinaryExpression

@srowen
Copy link
Member

srowen commented Jul 4, 2015

I understand the motivation, but I would oppose adding yet more config and API surface area unless there's a clear need. I don't see that this does much.

@SaintBacchus
Copy link
Contributor Author

adding yet more config and API surface area unless there's a clear need

@srowen Do you mean it's not necessary to add this config?
I purpose the user may not hard code the checkpoint directory or they must implement the config themself.

@andrewor14
Copy link
Contributor

@tdas

@SaintBacchus
Copy link
Contributor Author

@harishreedharan Can you also review this PR plz

@tdas
Copy link
Contributor

tdas commented Jul 13, 2015

Please added unit tests in StreamingContextSuite

@SparkQA
Copy link

SparkQA commented Jul 14, 2015

Test build #37224 has finished for PR 7218 at commit 66ea47c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this configuration to spark.streaming.checkpoint.directory. This is to maintain cleanliness in the future if we add more configuration related to checkpointing (spark.streaming.checkpoint.*)

@harishreedharan
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Jul 15, 2015

Test build #37295 has finished for PR 7218 at commit d49fe4b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in f957796 Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants