-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-8820][Streaming] Add a configuration to set checkpoint dir. #7218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #36521 has finished for PR 7218 at commit
|
|
I understand the motivation, but I would oppose adding yet more config and API surface area unless there's a clear need. I don't see that this does much. |
@srowen Do you mean it's not necessary to add this config? |
|
@harishreedharan Can you also review this PR plz |
|
Please added unit tests in StreamingContextSuite |
|
Test build #37224 has finished for PR 7218 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename this configuration to spark.streaming.checkpoint.directory. This is to maintain cleanliness in the future if we add more configuration related to checkpointing (spark.streaming.checkpoint.*)
|
LGTM |
|
Test build #37295 has finished for PR 7218 at commit
|
Add a configuration to set checkpoint directory for convenience to user.
Jira Address