Skip to content

[SPARK-8621] [SQL] support empty string as column name #7149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-8621] [SQL] support empty string as column name #7149

wants to merge 1 commit into from

Conversation

@cloud-fan
Copy link
Contributor

@cloud-fan cloud-fan commented Jul 1, 2015

improve the empty check in parseAttributeName so that we can allow empty string as column name.
Close #7117

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 1, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 1, 2015

Merged build started.

@cloud-fan cloud-fan mentioned this pull request Jul 1, 2015
Closed
@cloud-fan
Copy link
Contributor Author

cloud-fan commented Jul 1, 2015

cc @rxin

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36233 has started for PR 7149 at commit a9c6c1d.

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36233 has finished for PR 7149 at commit a9c6c1d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 1, 2015

Merged build finished. Test FAILed.

animeshbaranawal
animeshbaranawal reviewed Jul 1, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala Outdated
Copy link

@animeshbaranawal animeshbaranawal Jul 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the double inverted commas should be single.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 1, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 1, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36239 has started for PR 7149 at commit efa9e3e.

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36239 has finished for PR 7149 at commit efa9e3e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 1, 2015

Merged build finished. Test PASSed.

@rxin
Copy link
Contributor

rxin commented Jul 1, 2015

Thanks - merging in master.

@rxin
Copy link
Contributor

rxin commented Jul 1, 2015

and branch-1.4.

@asfgit asfgit closed this in 31b4a3d Jul 1, 2015
asfgit pushed a commit that referenced this pull request Jul 1, 2015
@cloud-fan @rxin
[SPARK-8621] [SQL] support empty string as column name
2f85d8e 
improve the empty check in `parseAttributeName` so that we can allow empty string as column name.
Close #7117

Author: Wenchen Fan <[email protected]>

Closes #7149 from cloud-fan/8621 and squashes the following commits:

efa9e3e [Wenchen Fan] support empty string

(cherry picked from commit 31b4a3d)
Signed-off-by: Reynold Xin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cloud-fan @AmplabJenkins @SparkQA @rxin @animeshbaranawal