Skip to content

[SPARK-8355] [SQL] Python DataFrameReader/Writer should mirror Scala #7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-8355] [SQL] Python DataFrameReader/Writer should mirror Scala #7078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
524e0aa
Add option function to df reader and writer
Jun 29, 2015
c63d419
Fix version
Jun 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions python/pyspark/sql/readwriter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,13 @@ def schema(self, schema):
self._jreader = self._jreader.schema(jschema)
return self

@since(1.5)
def option(self, key, value):
"""Adds an input option for the underlying data source.
"""
self._jreader = self._jreader.option(key, value)
return self

@since(1.4)
def options(self, **options):
"""Adds input options for the underlying data source.
Expand Down Expand Up @@ -235,6 +242,13 @@ def format(self, source):
self._jwrite = self._jwrite.format(source)
return self

@since(1.5)
def option(self, key, value):
"""Adds an output option for the underlying data source.
"""
self._jwrite = self._jwrite.option(key, value)
return self

@since(1.4)
def options(self, **options):
"""Adds output options for the underlying data source.
Expand Down
1 change: 1 addition & 0 deletions python/pyspark/sql/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,7 @@ def test_save_and_load_builder(self):
self.assertEqual(sorted(df.collect()), sorted(actual.collect()))

df.write.mode("overwrite").options(noUse="this options will not be used in save.")\
.option("noUse", "this option will not be used in save.")\
.format("json").save(path=tmpPath)
actual =\
self.sqlCtx.read.format("json")\
Expand Down