-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-8596][EC2] Added port for Rstudio #7068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
Jenkins, add to whitelist |
|
Jenkins, ok to test |
ec2/spark_ec2.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really minor but could you add a comment on the line before saying this is for RStudio ? Might help others figure out why this port is open
|
Merged build triggered. |
|
Merged build started. |
|
Test build #35945 has started for PR 7068 at commit |
|
Test build #35945 has finished for PR 7068 at commit
|
|
Merged build finished. Test FAILed. |
|
Merged build triggered. |
|
Merged build started. |
|
@shivaram. Comment might make sense (I didn't add because most ports didn't have comments). Comment added. |
|
Test build #35946 has started for PR 7068 at commit |
|
Test build #35946 has finished for PR 7068 at commit
|
|
Merged build finished. Test FAILed. |
|
just out of curiosity. what is making this test fail? |
|
The tests are not actually failing. The message from SparkQA is the one to use (it says passes all tests). There is a bug in the AmplabJenkins messages that @JoshRosen is looking into. LGTM. Thanks @koaning for the patch. Merging this |
This would otherwise need to be set manually by R users in AWS.
https://issues.apache.org/jira/browse/SPARK-8596