Skip to content

Conversation

@litao-buptsse
Copy link
Contributor

[SPARK-8657] [YARN] Simplify method addResource() and get the correct fs from destPath.

JIRA Link: https://issues.apache.org/jira/browse/SPARK-8657

@srowen
Copy link
Member

srowen commented Jun 27, 2015

OK to test

@SparkQA
Copy link

SparkQA commented Jun 27, 2015

Test build #967 has finished for PR 7053 at commit 75b457e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Sha2(left: Expression, right: Expression)

@litao-buptsse
Copy link
Contributor Author

Some unit tests failed. I will review my PR code again.

@litao-buptsse litao-buptsse force-pushed the SPARK-8657-for-master branch from 8c95d08 to 75b457e Compare June 27, 2015 12:26
@litao-buptsse
Copy link
Contributor Author

@srowen I think maybe the first fs param in addResource() is needed, especially it's useful when doing unit test. I see the ClientDistributedCacheManagerSuite usually pass a mock fs to the addResource(). So I think to keep the first fs param might be better, although it's sometimes redundant.

ClientDistributedCacheManagerSuite unit tests: https://github.com/apache/spark/blob/master/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientDistributedCacheManagerSuite.scala

My failed unit tests: https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/967/testReport/org.apache.spark.deploy.yarn/

@srowen
Copy link
Member

srowen commented Jun 29, 2015

OK to test

@SparkQA
Copy link

SparkQA commented Jun 29, 2015

Test build #976 has finished for PR 7053 at commit 75b457e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@litao-buptsse litao-buptsse deleted the SPARK-8657-for-master branch June 30, 2015 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants