Skip to content

Conversation

@BenFradet
Copy link
Contributor

Follow up of SPARK-8356 and #6902.
Removes the unit test for the now deprecated callUdf
Unit test in SQLQuerySuite now uses udf instead of callUDF
Replaced callUDF by udf where possible in mllib

@SparkQA
Copy link

SparkQA commented Jun 24, 2015

Test build #35711 has finished for PR 6993 at commit fe2a10b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@BenFradet
Copy link
Contributor Author

Pinging @marmbrus

@marmbrus
Copy link
Contributor

/cc @mengxr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit: I think we call udf above so the invocation just looks like init().

@BenFradet
Copy link
Contributor Author

Thanks a lot for your input @mengxr, will update the pr accordingly.

@BenFradet BenFradet changed the title [Spark-8575][SQL] Deprecate callUDF in favor of udf [SPARK-8575][SQL] Deprecate callUDF in favor of udf Jun 25, 2015
@SparkQA
Copy link

SparkQA commented Jun 25, 2015

Test build #35808 has finished for PR 6993 at commit 0ebd0da.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 26, 2015

Test build #35865 has finished for PR 6993 at commit 1ddb452.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 26, 2015

Test build #35867 has finished for PR 6993 at commit 26f5a7a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@BenFradet
Copy link
Contributor Author

pinging @mengxr and @marmbrus, there is still one occurrence left of callUDF in Transformer but I don't think we can replace this one by udf, can we?

@mengxr
Copy link
Contributor

mengxr commented Jun 29, 2015

@BenFradet I don't think it is easy to replace that one because of outputDataType. The changes LGTM. Merged into master. Thanks!

@asfgit asfgit closed this in 0b10662 Jun 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants