[SPARK-8578] [SQL] Should ignore user defined output committer when appending data #6964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Will create a PR for 1.4 branch. |
Contributor
|
LGTM except for several minor stuff. |
Contributor
Author
|
test this please. |
|
Test build #35607 has finished for PR 6964 at commit
|
|
Test build #35617 has finished for PR 6964 at commit
|
Contributor
Author
|
test this please |
Contributor
|
Typo in the PR title, should be [SPARK-8578] |
yhuai
changed the title
Contributor
Author
|
Changed. Thanks! |
|
Test build #35625 has finished for PR 6964 at commit
|
|
Test build #35639 has finished for PR 6964 at commit
|
Contributor
Author
|
Thanks for reviewing it! I am merging it to master. |
asfgit
pushed a commit
that referenced
this pull request
Jun 24, 2015
…ppending data (branch 1.4) This is #6964 for branch 1.4. Author: Yin Huai <[email protected]> Closes #6966 from yhuai/SPARK-8578-branch-1.4 and squashes the following commits: 9c3947b [Yin Huai] Do not use a custom output commiter when appendiing data.
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 25, 2015
…ppending data (branch 1.4) This is apache#6964 for branch 1.4. Author: Yin Huai <[email protected]> Closes apache#6966 from yhuai/SPARK-8578-branch-1.4 and squashes the following commits: 9c3947b [Yin Huai] Do not use a custom output commiter when appendiing data.
Contributor
|
@JoshRosen It's a little bit weird that this PR still appears in the PR dashboard even it's merged and closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-8578
It is not very safe to use a custom output committer when append data to an existing dir. This changes adds the logic to check if we are appending data, and if so, we use the output committer associated with the file output format.