[SPARK-8576] Add spark-ec2 options to set IAM roles and instance-initiated shutdown behavior #6962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #35600 has finished for PR 6962 at commit
|
Contributor
Author
|
cc @JoshRosen |
|
Test build #35601 has finished for PR 6962 at commit
|
|
Merged build finished. Test FAILed. |
Contributor
There was a problem hiding this comment.
Just curious -- is boto happy if we pass in None here ?
Contributor
Author
There was a problem hiding this comment.
None should be fine, but I'll double check that and empty string tomorrow.
Contributor
Author
There was a problem hiding this comment.
Yup, both None (i.e. leaving out the option) and empty string work fine.
Contributor
|
Thanks for checking. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these options are useful when spark-ec2 is being used as part of an automated pipeline and the engineers want to minimize the need to pass around AWS keys for access to things like S3 (keys are replaced by the IAM role) and to be able to launch a cluster that can terminate itself cleanly.