Skip to content

[SPARK-8563] [MLlib] Fixed a bug so that IndexedRowMatrix.computeSVD().U.numCols = k #6953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SPARK-8563] [MLlib] Fixed a bug so that IndexedRowMatrix.computeSVD().U.numCols = k #6953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8373424
[SPARK-8563][MLlib] Fixed a bug so that IndexedRowMatrix.computeSVD()…
lee19 Jun 23, 2015
c2ccd89
Added a unit test that validates matrix sizes of svd for [SPARK-8563]…
lee19 Jun 23, 2015
4b9803b
[SPARK-8563] [MLlib] Fixed a build error.
lee19 Jun 26, 2015
c1812a0
[SPARK-8563] [MLlib] Used nRows instead of numRows() to reduce a burden.
lee19 Jun 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/IndexedRowMatrix.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ class IndexedRowMatrix(
val indexedRows = indices.zip(svd.U.rows).map { case (i, v) =>
IndexedRow(i, v)
}
new IndexedRowMatrix(indexedRows, nRows, nCols)
new IndexedRowMatrix(indexedRows, nRows, svd.U.numCols().toInt)
} else {
null
}
Expand Down
11 changes: 11 additions & 0 deletions mllib/src/test/scala/org/apache/spark/mllib/linalg/distributed/IndexedRowMatrixSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,17 @@ class IndexedRowMatrixSuite extends SparkFunSuite with MLlibTestSparkContext {
assert(closeToZero(U * brzDiag(s) * V.t - localA))
}

test("validate matrix sizes of svd") {
val k = 2
val A = new IndexedRowMatrix(indexedRows)
val svd = A.computeSVD(k, computeU = true)
assert(svd.U.numRows() === m)
assert(svd.U.numCols() === k)
assert(svd.s.size === k)
assert(svd.V.numRows === n)
assert(svd.V.numCols === k)
}

test("validate k in svd") {
val A = new IndexedRowMatrix(indexedRows)
intercept[IllegalArgumentException] {
Expand Down