Skip to content

Conversation

@yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Jun 23, 2015

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jun 23, 2015

@davies Could you review it please when you have time? Thanks!

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35524 has finished for PR 6947 at commit 5ca240c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

@yu-iskw These files are not actually a part of the repo right ? I see that they are generated during the build but we don't ship them as source code, so I'm not sure we need to add them to rat-excludes ?

@JoshRosen
Copy link
Contributor

@shivaram, I think the motivation here is to address local dev/run-tests failures that are caused by the presence of these documentation files:

[joshrosen Spark (master)]$ ./dev/run-tests
[warn] Java 8 tests will not run because JDK version is < 1.8.
[info] Using build tool sbt with Hadoop profile hadoop2.3 under environment local
[info] Found the following changed modules: root

========================================================================
Running Apache RAT checks
========================================================================
Could not find Apache license headers in the following files:
 !????? /Users/joshrosen/Documents/spark/R/lib/SparkR/help/AnIndex
 !????? /Users/joshrosen/Documents/spark/R/lib/SparkR/help/SparkR.rdb
 !????? /Users/joshrosen/Documents/spark/R/lib/SparkR/html/00Index.html
 !????? /Users/joshrosen/Documents/spark/R/lib/SparkR/html/R.css
('[error] running', '/Users/joshrosen/Documents/spark/dev/check-license', '; received return code', 1)

@shivaram
Copy link
Contributor

Ah okay. In that case I'm fine with adding this. If the existing patch fixes the problem feel free to merge it

@JoshRosen
Copy link
Contributor

Great; merging to master.

@asfgit asfgit closed this in 715f084 Jun 29, 2015
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jun 30, 2015

@JoshRosen Thank you for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants