Skip to content

Conversation

@yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Jun 23, 2015

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jun 23, 2015

@shivaram Could you review it please when you have time? Thanks!

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35496 has finished for PR 6945 at commit 0bd567a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • // class ParentClass(parentField: Int)
    • // class ChildClass(childField: Int) extends ParentClass(1)
    • // If the class type corresponding to current slot has writeObject() defined,
    • // then its not obvious which fields of the class will be serialized as the writeObject()
    • class SerializableConfiguration(@transient var value: Configuration) extends Serializable
    • class SerializableJobConf(@transient var value: JobConf) extends Serializable
    • class Module(object):
    • class NGram(override val uid: String)
    • class StreamingKMeansModel(KMeansModel):
    • class StreamingKMeans(object):
    • class PCAModel(JavaVectorTransformer):
    • class PCA(object):
    • case class UnresolvedAlias(child: Expression) extends NamedExpression
    • abstract class ExtractValueWithStruct extends ExtractValue
    • abstract class GeneratedClass
    • case class Bin(child: Expression)
    • case class Md5(child: Expression)

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@shivaram
Copy link
Contributor

Thanks @yu-iskw -- LGTM. Merging this

asfgit pushed a commit that referenced this pull request Jun 23, 2015
… files

[[SPARK-8548] Remove the trailing whitespaces from the SparkR files - ASF JIRA](https://issues.apache.org/jira/browse/SPARK-8548)

- This is the result of `lint-r`
    https://gist.github.com/yu-iskw/0019b37a2c1167f33986

Author: Yu ISHIKAWA <[email protected]>

Closes #6945 from yu-iskw/SPARK-8548 and squashes the following commits:

0bd567a [Yu ISHIKAWA] [SPARK-8548][SparkR] Remove the trailing whitespaces from the SparkR files

(cherry picked from commit 44fa7df)
Signed-off-by: Shivaram Venkataraman <[email protected]>
@shivaram
Copy link
Contributor

Also FYI I also backported this to branch-1.4 as it'll make future cherry-picks easier.

@asfgit asfgit closed this in 44fa7df Jun 23, 2015
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jun 23, 2015

@shivaram Thank you for merging it!

nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 25, 2015
… files

[[SPARK-8548] Remove the trailing whitespaces from the SparkR files - ASF JIRA](https://issues.apache.org/jira/browse/SPARK-8548)

- This is the result of `lint-r`
    https://gist.github.com/yu-iskw/0019b37a2c1167f33986

Author: Yu ISHIKAWA <[email protected]>

Closes apache#6945 from yu-iskw/SPARK-8548 and squashes the following commits:

0bd567a [Yu ISHIKAWA] [SPARK-8548][SparkR] Remove the trailing whitespaces from the SparkR files

(cherry picked from commit 44fa7df)
Signed-off-by: Shivaram Venkataraman <[email protected]>
animeshbaranawal pushed a commit to animeshbaranawal/spark that referenced this pull request Jun 25, 2015
… files

[[SPARK-8548] Remove the trailing whitespaces from the SparkR files - ASF JIRA](https://issues.apache.org/jira/browse/SPARK-8548)

- This is the result of `lint-r`
    https://gist.github.com/yu-iskw/0019b37a2c1167f33986

Author: Yu ISHIKAWA <[email protected]>

Closes apache#6945 from yu-iskw/SPARK-8548 and squashes the following commits:

0bd567a [Yu ISHIKAWA] [SPARK-8548][SparkR] Remove the trailing whitespaces from the SparkR files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants