[SPARK-8111] [SparkR] SparkR shell should display Spark logo and version banner on startup. #6944
Conversation
…spark version is taken from the environment variable SPARK_VERSION
|
nice! @shivaram |
|
ok to test. @aloknsingh Can you post a screenshot of what the logo looks like? |
|
Test build #35501 has finished for PR 6944 at commit
|
R/pkg/inst/profile/shell.R
Outdated
There was a problem hiding this comment.
We can remove SparkR from here and just make this Welcome to. That way the entire sentence will read Welcome to Spark
|
Thanks @aloknsingh for the change. I had some minor comments inline. Also to reply to your question from the JIRA I'd say we can just keep the ASCII art as |
…rkContext rather than the Sys.env. 2) change "Welcome to SparkR!" to "Welcome to" followed by Spark logo and version
|
@shivaram : I modified the code as per your suggestions. @andrewor14 : Here is the screenshot. |
|
Test build #35564 has finished for PR 6944 at commit
|
|
Jenkins. Please retest. |
|
@aloknsingh Actually the tests passed if you look at the Spark QA message (above the jenkins one) -- the jenkins plugin has an issue where it reports failures for some builds. |
|
retest this please |
|
LGTM. Will merge once tests pass |
|
Hm, this should have just run the R tests. |
|
Yeah I have no idea why that changed -- @JoshRosen did the limited unit test running thing change again ? |
|
It looks like the pull request builder somehow thinks that the |
|
hmm maybe it compared this PR to a different cached git commit ? I've seen that produce warnings for new classes added etc. before |
|
There might have been a race if a PR that changed SQL was committed between the time that the PRB was triggered with a merge commit and the time that we fetched origin/master to do a comparison for changed files. We can probably fix this by using a different base / SHA to compute the diff. |
|
Test build #35565 has finished for PR 6944 at commit
|
5 participants
spark version is taken from the environment variable SPARK_VERSION