Skip to content

[SPARK-8095] Resolve dependencies of --packages in local ivy cache #6788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[SPARK-8095] Resolve dependencies of --packages in local ivy cache #6788

wants to merge 6 commits into from

Conversation

@brkyvz
Copy link
Contributor

@brkyvz brkyvz commented Jun 12, 2015

Dependencies of artifacts in the local ivy cache were not being resolved properly. The dependencies were not being picked up. Now they should be.

cc @andrewor14

brkyvz
brkyvz reviewed Jun 12, 2015
View reviewed changes
core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala
Copy link
Contributor Author

@brkyvz brkyvz Jun 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this dependency as a regression test

@SparkQA
Copy link

SparkQA commented Jun 12, 2015

Test build #34785 has finished for PR 6788 at commit b6ef038.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

andrewor14 commented Jun 12, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Jun 12, 2015

Test build #909 has finished for PR 6788 at commit b6ef038.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 12, 2015

Test build #34797 has finished for PR 6788 at commit b6ef038.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 13, 2015

Test build #910 timed out for PR 6788 at commit b6ef038 after a configured wait of 175m.

@andrewor14
Copy link
Contributor

andrewor14 commented Jun 13, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Jun 14, 2015

Test build #34850 has finished for PR 6788 at commit b6ef038.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

andrewor14 commented Jun 14, 2015

@brkyvz there seems to a legitimate test failure

@SparkQA
Copy link

SparkQA commented Jun 16, 2015

Test build #35001 has finished for PR 6788 at commit 0037197.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 16, 2015

Test build #35000 has finished for PR 6788 at commit f60772c.

  • This patch fails Spark unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 16, 2015

Test build #35007 has finished for PR 6788 at commit a69e3e6.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 17, 2015

Test build #35016 has finished for PR 6788 at commit 48cc648.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 17, 2015

Test build #35021 has finished for PR 6788 at commit 2875bf4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

andrewor14 commented Jun 17, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Jun 17, 2015

Test build #35048 timed out for PR 6788 at commit 2875bf4 after a configured wait of 175m.

@andrewor14
Copy link
Contributor

andrewor14 commented Jun 17, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Jun 17, 2015

Test build #35060 has finished for PR 6788 at commit 2875bf4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

andrewor14 commented Jun 18, 2015

Merging into master 1.4 thanks Burak

@asfgit asfgit closed this in 3b61077 Jun 18, 2015
asfgit pushed a commit that referenced this pull request Jun 18, 2015
@brkyvz
[SPARK-8095] Resolve dependencies of --packages in local ivy cache
9dabc12 
Dependencies of artifacts in the local ivy cache were not being resolved properly. The dependencies were not being picked up. Now they should be.

cc andrewor14

Author: Burak Yavuz <[email protected]>

Closes #6788 from brkyvz/local-ivy-fix and squashes the following commits:

2875bf4 [Burak Yavuz] fix temp dir bug
48cc648 [Burak Yavuz] improve deletion
a69e3e6 [Burak Yavuz] delete cache before test as well
0037197 [Burak Yavuz] fix merge conflicts
f60772c [Burak Yavuz] use different folder for m2 cache during testing
b6ef038 [Burak Yavuz] [SPARK-8095] Resolve dependencies of Spark Packages in local ivy cache

Conflicts:
	core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala
@andrewor14
Copy link
Contributor

andrewor14 commented Jun 18, 2015

@brkyvz could you open a patch against branch-1.3? It doesn't merge cleanly there.

nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@brkyvz @nemccarthy
[SPARK-8095] Resolve dependencies of --packages in local ivy cache
57ae6a4 
Dependencies of artifacts in the local ivy cache were not being resolved properly. The dependencies were not being picked up. Now they should be.

cc andrewor14

Author: Burak Yavuz <[email protected]>

Closes apache#6788 from brkyvz/local-ivy-fix and squashes the following commits:

2875bf4 [Burak Yavuz] fix temp dir bug
48cc648 [Burak Yavuz] improve deletion
a69e3e6 [Burak Yavuz] delete cache before test as well
0037197 [Burak Yavuz] fix merge conflicts
f60772c [Burak Yavuz] use different folder for m2 cache during testing
b6ef038 [Burak Yavuz] [SPARK-8095] Resolve dependencies of Spark Packages in local ivy cache
@brkyvz brkyvz mentioned this pull request Jun 21, 2015
Closed
asfgit pushed a commit that referenced this pull request Jun 22, 2015
@brkyvz
[SPARK-8095][BACKPORT] Resolve dependencies of --packages in local iv…
45b4527 
…y cache

Backported PR #6788

cc andrewor14

Author: Burak Yavuz <[email protected]>

Closes #6923 from brkyvz/backport-local-ivy and squashes the following commits:

eb17384 [Burak Yavuz] [SPARK-8095][BACKPORT] Resolve dependencies of --packages in local ivy cache
mtbrandy pushed a commit to ibmsoe/spark that referenced this pull request Jul 2, 2015
@brkyvz @mtbrandy
[SPARK-8095] Resolve dependencies of --packages in local ivy cache
e5e1a87 
Dependencies of artifacts in the local ivy cache were not being resolved properly. The dependencies were not being picked up. Now they should be.

cc andrewor14

Author: Burak Yavuz <[email protected]>

Closes apache#6788 from brkyvz/local-ivy-fix and squashes the following commits:

2875bf4 [Burak Yavuz] fix temp dir bug
48cc648 [Burak Yavuz] improve deletion
a69e3e6 [Burak Yavuz] delete cache before test as well
0037197 [Burak Yavuz] fix merge conflicts
f60772c [Burak Yavuz] use different folder for m2 cache during testing
b6ef038 [Burak Yavuz] [SPARK-8095] Resolve dependencies of Spark Packages in local ivy cache

Conflicts:
	core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala
@brkyvz brkyvz deleted the local-ivy-fix branch February 3, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brkyvz @SparkQA @andrewor14