[SPARK-8215] [SPARK-8212] [SQL] add leaf math expression for e and pi

[adrian-wang]

No description provided.

[SparkQA]

Test build #34493 has finished for PR 6716 at commit 6fa757e.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • abstract class LeafMathExpression(c: Double, name: String)
  • case class E() extends LeafMathExpression(math.E, "E")
  • case class Pi() extends LeafMathExpression(math.Pi, "PI")

[SparkQA]

Test build #34501 has finished for PR 6716 at commit e6783ef.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • abstract class LeafMathExpression(c: Double, name: String)
  • case class E() extends LeafMathExpression(math.E, "E")
  • case class Pi() extends LeafMathExpression(math.Pi, "PI")

[SparkQA]

Test build #34498 timed out for PR 6716 at commit 00f6b59 after a configured wait of 175m.

[rxin]

Why not just use the java.math definition, i.e.

The double value that is closer than any other to e, the base of the natural logarithms.

[rxin]

Can you also add the Python version? Thanks.

[rxin]

why not just ...

 ${ctx.javaType(dataType)} ${ev.primitive} = java.lang.Math.$constName;

[SparkQA]

Test build #34560 has finished for PR 6716 at commit 599ddd8.

• This patch fails Python style tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • abstract class LeafMathExpression(c: Double, name: String)
  • case class E() extends LeafMathExpression(math.E, "E")
  • case class Pi() extends LeafMathExpression(math.Pi, "PI")

[rxin]

i don't think u need this, since you explicitly defined it. you might need to add it to all at the top of the file

[rxin]

let's be consistent with @chenghao-intel's length pr, and move this test into DataFrameFunctionSuite.scala.

[adrian-wang]

OK. Anyway, I think it looks weird to test sql() in DataFrameFunctionsSuite.

[rxin]

LGTM.

[SparkQA]

Test build #34562 has finished for PR 6716 at commit db331c9.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • abstract class LeafMathExpression(c: Double, name: String)
  • case class E() extends LeafMathExpression(math.E, "E")
  • case class Pi() extends LeafMathExpression(math.Pi, "PI")

[rxin]

Jenkins, retest this please.

[rxin]

(want to test with this HiveContext also switching to using udfs here)

[SparkQA]

Test build #34567 has finished for PR 6716 at commit 11b351c.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • abstract class LeafMathExpression(c: Double, name: String)
  • case class EulerNumber() extends LeafMathExpression(math.E, "E")
  • case class Pi() extends LeafMathExpression(math.Pi, "PI")

[SparkQA]

Test build #34576 has finished for PR 6716 at commit e2e8dbd.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • abstract class LeafMathExpression(c: Double, name: String)
  • case class EulerNumber() extends LeafMathExpression(math.E, "E")
  • case class Pi() extends LeafMathExpression(math.Pi, "PI")

[SparkQA]

Test build #34582 has finished for PR 6716 at commit e2e8dbd.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • abstract class LeafMathExpression(c: Double, name: String)
  • case class EulerNumber() extends LeafMathExpression(math.E, "E")
  • case class Pi() extends LeafMathExpression(math.Pi, "PI")

[rxin]

Thanks. I've merged this.