[SPARK-7792] [SQL] HiveContext registerTempTable not thread safe #6699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Actually it's a bad idea to put a scala wrapper around java's ConcurrentHashMap. Do you mind just removing the wrapper, and change the call site to just use the functions defined in ConcurrentHashMap?
Also would be great to mark tables as a private val.
Contributor
There was a problem hiding this comment.
For more background, see https://github.com/databricks/scala-style-guide#concurrency
Contributor
Author
There was a problem hiding this comment.
Oh, is it? Thanks. I got it.
Contributor
|
Jenkins, test this please. |
|
Test build #34543 has finished for PR 6699 at commit
|
Contributor
|
Jenkins, test this please. |
|
Test build #34549 has finished for PR 6699 at commit
|
Contributor
|
Thanks. I'm going to merge this into master. |
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
Just replaced mutable.HashMap to ConcurrentHashMap Author: navis.ryu <[email protected]> Closes apache#6699 from navis/SPARK-7792 and squashes the following commits: f03654a [navis.ryu] [SPARK-7792] [SQL] HiveContext registerTempTable not thread safe
mbautin
pushed a commit
to mbautin/spark
that referenced
this pull request
Jun 21, 2015
Just replaced mutable.HashMap to ConcurrentHashMap Author: navis.ryu <[email protected]> Closes apache#6699 from navis/SPARK-7792 and squashes the following commits: f03654a [navis.ryu] [SPARK-7792] [SQL] HiveContext registerTempTable not thread safe Conflicts: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just replaced mutable.HashMap to ConcurrentHashMap