Skip to content

[SPARK-8049] [MLLIB] drop tmp col from OneVsRest output #6592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-8049] [MLLIB] drop tmp col from OneVsRest output #6592

wants to merge 2 commits into from

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Jun 2, 2015

The temporary column should be dropped after we get the prediction column. @harsha2010

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #34018 has finished for PR 6592 at commit 6ee70de.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@harsha2010
Copy link

harsha2010 commented Jun 2, 2015

+1 looks good. thanks @mengxr
I do have one question: does it make sense to promote this column which actually stores the predictions of the underlying classifiers for debugging purposes. For a test example, if my classification error is high, it would be nice to be able to inspect this column for debugging.

@mengxr
Copy link
Contributor Author

mengxr commented Jun 2, 2015

We could add a debug flag (or debugLevel) in the future to control extra columns. By default, users shouldn't see this column.

@harsha2010
Copy link

harsha2010 commented Jun 2, 2015

@mengxr , yes, that works. thanks!

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #34024 has finished for PR 6592 at commit 1d89107.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 89f21f6 Jun 2, 2015
asfgit pushed a commit that referenced this pull request Jun 2, 2015
@mengxr
[SPARK-8049] [MLLIB] drop tmp col from OneVsRest output
97d4cd0 
The temporary column should be dropped after we get the prediction column. harsha2010

Author: Xiangrui Meng <[email protected]>

Closes #6592 from mengxr/SPARK-8049 and squashes the following commits:

1d89107 [Xiangrui Meng] use SparkFunSuite
6ee70de [Xiangrui Meng] drop tmp col from OneVsRest output

(cherry picked from commit 89f21f6)
Signed-off-by: Xiangrui Meng <[email protected]>
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@mengxr @jeanlyn
[SPARK-8049] [MLLIB] drop tmp col from OneVsRest output
53fc7db 
The temporary column should be dropped after we get the prediction column. harsha2010

Author: Xiangrui Meng <[email protected]>

Closes apache#6592 from mengxr/SPARK-8049 and squashes the following commits:

1d89107 [Xiangrui Meng] use SparkFunSuite
6ee70de [Xiangrui Meng] drop tmp col from OneVsRest output
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@mengxr @nemccarthy
[SPARK-8049] [MLLIB] drop tmp col from OneVsRest output
8bbabcf 
The temporary column should be dropped after we get the prediction column. harsha2010

Author: Xiangrui Meng <[email protected]>

Closes apache#6592 from mengxr/SPARK-8049 and squashes the following commits:

1d89107 [Xiangrui Meng] use SparkFunSuite
6ee70de [Xiangrui Meng] drop tmp col from OneVsRest output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mengxr @SparkQA @harsha2010