Skip to content

Conversation

@ogirardot
Copy link

The chaining of when functions was broken in PySpark SQL.
This fix is only changing the Column.py file to fix the when function accordingly.

Regards,

Olivier.

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33977 has finished for PR 6580 at commit 0d52b89.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ogirardot
Copy link
Author

Build seems to have failed because of something else...

@JoshRosen
Copy link
Contributor

Mind adding a regression test?

@pwendell
Copy link
Contributor

pwendell commented Jun 2, 2015

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33998 has finished for PR 6580 at commit 0d52b89.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #869 has finished for PR 6580 at commit 0d52b89.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor

davies commented Jun 2, 2015

Thanks for working on this, I'd create another PR #6590 based on yours, also find another bug in otherwise, adding tests for them.

asfgit pushed a commit that referenced this pull request Jun 2, 2015
Thanks ogirardot, closes #6580

cc rxin JoshRosen

Author: Davies Liu <[email protected]>

Closes #6590 from davies/when and squashes the following commits:

c0f2069 [Davies Liu] fix Column.when() and otherwise()

(cherry picked from commit 605ddbb)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 605ddbb Jun 2, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
Thanks ogirardot, closes apache#6580

cc rxin JoshRosen

Author: Davies Liu <[email protected]>

Closes apache#6590 from davies/when and squashes the following commits:

c0f2069 [Davies Liu] fix Column.when() and otherwise()
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
Thanks ogirardot, closes apache#6580

cc rxin JoshRosen

Author: Davies Liu <[email protected]>

Closes apache#6590 from davies/when and squashes the following commits:

c0f2069 [Davies Liu] fix Column.when() and otherwise()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants