Skip to content

[SPARK-3873] [build] Add style checker to enforce import ordering. #6502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SPARK-3873] [build] Add style checker to enforce import ordering. #6502

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aded027
[SPARK-3873] [build] Add scalastyle checker for import ordering.
Dec 3, 2015
c1e5556
Cleanup scalastyle script a little.
Dec 3, 2015
28e8287
Fix an unrelated typo.
Dec 3, 2015
ce52797
Merge branch 'master' into SPARK-3873
Dec 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion scalastyle-config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ This file is divided into 3 sections:
<check customId="visiblefortesting" level="error" class="org.scalastyle.file.RegexChecker" enabled="true">
<parameters><parameter name="regex">@VisibleForTesting</parameter></parameters>
<customMessage><![CDATA[
@VisibleForTesting auses classpath issues. Please note this in the java doc instead (SPARK-11615).
@VisibleForTesting causes classpath issues. Please note this in the java doc instead (SPARK-11615).
]]></customMessage>
</check>

Expand Down Expand Up @@ -203,6 +203,18 @@ This file is divided into 3 sections:
<!-- Should turn this on, but we have a few places that need to be fixed first -->
<check level="error" class="org.scalastyle.scalariform.EqualsHashCodeChecker" enabled="false"></check>

<!-- Import ordering. Currently warning only since there are lots of violations. -->
<check level="warning" class="org.scalastyle.scalariform.ImportOrderChecker" enabled="true">
<parameters>
<parameter name="groups">java,scala,3rdParty,spark</parameter>
<parameter name="group.java">javax?\..+</parameter>
<parameter name="group.scala">scala\..+</parameter>
<parameter name="group.3rdParty">(?!org\.apache\.spark\.).*</parameter>
<parameter name="group.spark">org\.apache\.spark\..*</parameter>
</parameters>
</check>


<!-- ================================================================================ -->
<!-- rules we don't want -->
<!-- ================================================================================ -->
Expand Down