Skip to content

[SPARK-7946] [MLlib] DecayFactor wrongly set in StreamingKMeans #6497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-7946] [MLlib] DecayFactor wrongly set in StreamingKMeans #6497

wants to merge 2 commits into from

Conversation

@MechCoder
Copy link
Contributor

@MechCoder MechCoder commented May 29, 2015

No description provided.

@MechCoder
Copy link
Contributor Author

MechCoder commented May 29, 2015

@mengxr can you please verify?

@srowen
Copy link
Member

srowen commented May 29, 2015

Looks like a good catch.

@SparkQA
Copy link

SparkQA commented May 29, 2015

Test build #33734 has finished for PR 6497 at commit 8c988c6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MechCoder
Copy link
Contributor Author

MechCoder commented May 29, 2015

I added a NRT. (Non Regression Test)

mengxr
mengxr reviewed May 29, 2015
View reviewed changes
mllib/src/test/scala/org/apache/spark/mllib/clustering/StreamingKMeansSuite.scala Outdated
Copy link
Contributor

@mengxr mengxr May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's simplify the test.

val kMeans = new StrreamingKMeans()
assert(kMeans.decayFactor === 1.0)
kMeans.setDecayFactor(2.0)
assert(kMeans.decayFactor === 2.0)

It is also useful to include the JIRA number in the test name, in case people wonder why we have this particular test.

@mengxr
Copy link
Contributor

mengxr commented May 29, 2015

Nice catch!

@SparkQA
Copy link

SparkQA commented May 29, 2015

Test build #33739 has finished for PR 6497 at commit 9e5fc1d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MechCoder
Copy link
Contributor Author

MechCoder commented May 29, 2015

@mengxr fixed! I have started work on the python bindings #6499 . Will ping you once it's done,

@mengxr
Copy link
Contributor

mengxr commented May 29, 2015

LGTM

@SparkQA
Copy link

SparkQA commented May 29, 2015

Test build #33747 has finished for PR 6497 at commit 2fdd0a3.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 29, 2015

Test build #33746 has finished for PR 6497 at commit bdf540c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request May 29, 2015
@MechCoder @mengxr
[SPARK-7946] [MLLIB] DecayFactor wrongly set in StreamingKMeans
ad5daa3 
Author: MechCoder <[email protected]>

Closes #6497 from MechCoder/spark-7946 and squashes the following commits:

2fdd0a3 [MechCoder] Add non-regression test
8c988c6 [MechCoder] [SPARK-7946] DecayFactor wrongly set in StreamingKMeans

(cherry picked from commit 6181937)
Signed-off-by: Xiangrui Meng <[email protected]>
asfgit pushed a commit that referenced this pull request May 29, 2015
@MechCoder @mengxr
[SPARK-7946] [MLLIB] DecayFactor wrongly set in StreamingKMeans
aefb113 
Author: MechCoder <[email protected]>

Closes #6497 from MechCoder/spark-7946 and squashes the following commits:

2fdd0a3 [MechCoder] Add non-regression test
8c988c6 [MechCoder] [SPARK-7946] DecayFactor wrongly set in StreamingKMeans

(cherry picked from commit 6181937)
Signed-off-by: Xiangrui Meng <[email protected]>
@asfgit asfgit closed this in 6181937 May 29, 2015
asfgit pushed a commit that referenced this pull request May 29, 2015
@MechCoder @mengxr
[SPARK-7946] [MLLIB] DecayFactor wrongly set in StreamingKMeans
4be701a 
Author: MechCoder <[email protected]>

Closes #6497 from MechCoder/spark-7946 and squashes the following commits:

2fdd0a3 [MechCoder] Add non-regression test
8c988c6 [MechCoder] [SPARK-7946] DecayFactor wrongly set in StreamingKMeans

(cherry picked from commit 6181937)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented May 29, 2015

Merged into master, branch-1.4, 1.3, and 1.2. Thanks! The R test failure is orthogonal to this PR. Ping @shivaram .

@shivaram
Copy link
Contributor

shivaram commented May 29, 2015

Hmm weird - The error logs have no information on what failed in this case. I'm guessing it was a transient problem, but let me know if you run into this again.

@MechCoder MechCoder deleted the spark-7946 branch May 29, 2015 20:02
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@MechCoder @jeanlyn
[SPARK-7946] [MLLIB] DecayFactor wrongly set in StreamingKMeans
adf8bc2 
Author: MechCoder <[email protected]>

Closes apache#6497 from MechCoder/spark-7946 and squashes the following commits:

2fdd0a3 [MechCoder] Add non-regression test
8c988c6 [MechCoder] [SPARK-7946] DecayFactor wrongly set in StreamingKMeans
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@MechCoder @nemccarthy
[SPARK-7946] [MLLIB] DecayFactor wrongly set in StreamingKMeans
c325d19 
Author: MechCoder <[email protected]>

Closes apache#6497 from MechCoder/spark-7946 and squashes the following commits:

2fdd0a3 [MechCoder] Add non-regression test
8c988c6 [MechCoder] [SPARK-7946] DecayFactor wrongly set in StreamingKMeans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MechCoder @srowen @SparkQA @mengxr @shivaram