-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-7042] [BUILD] use the standard akka artifacts with hadoop-2.x #6492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Both akka 2.3.x and hadoop-2.x use protobuf 2.5 so only hadoop-1 build needs custom 2.3.4-spark akka version that shades protobuf-2.5 This change also updates akka version (for hadoop-2.x profiles only) to the latest 2.3.11 as akka-zeromq_2.11 is not available for akka 2.3.4. This partially fixes SPARK-7042 (for hadoop-2.x builds)
|
OK to test |
|
Jenkins, add to whitelist |
|
Test build #33728 has finished for PR 6492 at commit
|
|
I'm inclined to pull this in if in fact it works with Scala 2.11 this time around, as reported on the JIRA. 2.3.11 is claimed to be a drop in replacement for earlier 2.3.x: http://akka.io/news/2015/05/12/akka-2.3.11-released.html Tests pass. OK to try out for master? @pwendell |
|
Yep LGTM |
Both akka 2.3.x and hadoop-2.x use protobuf 2.5 so only hadoop-1 build needs custom 2.3.4-spark akka version that shades protobuf-2.5 This change also updates akka version (for hadoop-2.x profiles only) to the latest 2.3.11 as akka-zeromq_2.11 is not available for akka 2.3.4. This partially fixes SPARK-7042 (for hadoop-2.x builds) Author: Konstantin Shaposhnikov <[email protected]> Closes #6492 from kostya-sh/SPARK-7042 and squashes the following commits: dc195b0 [Konstantin Shaposhnikov] [SPARK-7042] [BUILD] use the standard akka artifacts with hadoop-2.x
|
@kostya-sh I merged this, but it didn't auto-close due to a sync problem. You can close this PR. |
|
@srowen, thank you. Closing the pull request now. |
|
Heads up: This PR appears to have broken Spark when built against Hadoop 1. I've been having trouble coming up with a simple repro, but spark-perf tests succeed on preceding commits and fail starting precisely on this one. For the spark-perf tests, Spark is being built as follows: |
|
@nchammas, what errors are you getting? |
|
@nchammas, also what version of maven did you use to build Spark? A quick test shows that at least maven-3.1.1 is broken (by not taking active profile into account when resolving transitive dependencies) and maven-3.3.3 (the latest) seems to work. 3.1.1 (note that that both 2.3.11 and 2.3.4-spark akka versions are referenced): 3.3.3 (only 2.3.4-spark akka version) |
|
3.2.5 has the same issue, too |
|
So let's require Maven 3.3 -- problem solved! I'm going to just say it: what about dropping Hadoop 1.x support in Spark 1.5? Java 6 support is going away too. |
|
@kostya-sh @zsxwing - I was using Maven 3.2.5. Lemme try with 3.3 and confirm that that fixes things. The top level error was this: @srowen - Do you want to start a discussion on the dev list about both requiring Maven 3.3 and dropping Hadoop 1 support (perhaps in separate threads)? |
|
OK, I confirmed that using Maven 3.3.3 resolves my issue. |
Versions of Maven older than 3.3.0 apparently have [a bug in how they handle transitive dependencies](apache/spark#6492 (comment)). I confirmed that upgrading to Maven 3.3.3 resolves at least the particular manifestation of this bug that I ran into. Author: Nicholas Chammas <[email protected]> Closes #75 from nchammas/maven-333 and squashes the following commits: 3e751ab [Nicholas Chammas] Upgrade to latest Maven release
Versions of Maven older than 3.3.0 apparently have [a bug in how they handle transitive dependencies](#6492 (comment)). I confirmed that upgrading to Maven 3.3.3 resolves at least the particular manifestation of this bug that I ran into. Author: Nicholas Chammas <[email protected]> Closes #6770 from nchammas/maven-333 and squashes the following commits: 6bed2d9 [Nicholas Chammas] upgrade to Maven 3.3.3
Both akka 2.3.x and hadoop-2.x use protobuf 2.5 so only hadoop-1 build needs custom 2.3.4-spark akka version that shades protobuf-2.5 This change also updates akka version (for hadoop-2.x profiles only) to the latest 2.3.11 as akka-zeromq_2.11 is not available for akka 2.3.4. This partially fixes SPARK-7042 (for hadoop-2.x builds) Author: Konstantin Shaposhnikov <[email protected]> Closes apache#6492 from kostya-sh/SPARK-7042 and squashes the following commits: dc195b0 [Konstantin Shaposhnikov] [SPARK-7042] [BUILD] use the standard akka artifacts with hadoop-2.x
Versions of Maven older than 3.3.0 apparently have [a bug in how they handle transitive dependencies](apache#6492 (comment)). I confirmed that upgrading to Maven 3.3.3 resolves at least the particular manifestation of this bug that I ran into. Author: Nicholas Chammas <[email protected]> Closes apache#6770 from nchammas/maven-333 and squashes the following commits: 6bed2d9 [Nicholas Chammas] upgrade to Maven 3.3.3
Both akka 2.3.x and hadoop-2.x use protobuf 2.5 so only hadoop-1 build needs
custom 2.3.4-spark akka version that shades protobuf-2.5
This change also updates akka version (for hadoop-2.x profiles only) to the
latest 2.3.11 as akka-zeromq_2.11 is not available for akka 2.3.4.
This partially fixes SPARK-7042 (for hadoop-2.x builds)