[SPARK-7927] whitespace fixes for SQL core. #6477
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
So, has something changed in the community's previous assessment that making these large, style-only changes are not worth it (because they can make merges difficult, and also make history / git blame harder to figure out)? I still have the code for SPARK-3873 which should still work - 99% of the patch is just fixing the existing source files. |
|
Test build #33690 has finished for PR 6477 at commit
|
Contributor
There was a problem hiding this comment.
Why do we want to turn off the check here?
Contributor
Author
There was a problem hiding this comment.
just too many things I didn't bother changing.
Contributor
There was a problem hiding this comment.
I see... Regex replacing rocks here :)
|
Test build #33699 has finished for PR 6477 at commit
|
asfgit
pushed a commit
that referenced
this pull request
May 29, 2015
So we can enable a whitespace enforcement rule in the style checker to save code review time. Author: Reynold Xin <[email protected]> Closes #6477 from rxin/whitespace-sql-core and squashes the following commits: ce6e369 [Reynold Xin] Fixed tests. 6095fed [Reynold Xin] [SPARK-7927] whitespace fixes for SQL core. (cherry picked from commit ff44c71) Signed-off-by: Reynold Xin <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
May 29, 2015
This is the last batch of changes to complete SPARK-7929. Previous related PRs: #6480 #6478 #6477 #6476 #6475 #6474 #6473 Author: Reynold Xin <[email protected]> Closes #6487 from rxin/whitespace-lint and squashes the following commits: b33d43d [Reynold Xin] [SPARK-7929] Turn whitespace checker on for more token types.
asfgit
pushed a commit
that referenced
this pull request
May 29, 2015
This is the last batch of changes to complete SPARK-7929. Previous related PRs: #6480 #6478 #6477 #6476 #6475 #6474 #6473 Author: Reynold Xin <[email protected]> Closes #6487 from rxin/whitespace-lint and squashes the following commits: b33d43d [Reynold Xin] [SPARK-7929] Turn whitespace checker on for more token types. (cherry picked from commit 97a60cf) Signed-off-by: Reynold Xin <[email protected]>
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
So we can enable a whitespace enforcement rule in the style checker to save code review time. Author: Reynold Xin <[email protected]> Closes apache#6477 from rxin/whitespace-sql-core and squashes the following commits: ce6e369 [Reynold Xin] Fixed tests. 6095fed [Reynold Xin] [SPARK-7927] whitespace fixes for SQL core.
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
This is the last batch of changes to complete SPARK-7929. Previous related PRs: apache#6480 apache#6478 apache#6477 apache#6476 apache#6475 apache#6474 apache#6473 Author: Reynold Xin <[email protected]> Closes apache#6487 from rxin/whitespace-lint and squashes the following commits: b33d43d [Reynold Xin] [SPARK-7929] Turn whitespace checker on for more token types.
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
So we can enable a whitespace enforcement rule in the style checker to save code review time. Author: Reynold Xin <[email protected]> Closes apache#6477 from rxin/whitespace-sql-core and squashes the following commits: ce6e369 [Reynold Xin] Fixed tests. 6095fed [Reynold Xin] [SPARK-7927] whitespace fixes for SQL core.
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
This is the last batch of changes to complete SPARK-7929. Previous related PRs: apache#6480 apache#6478 apache#6477 apache#6476 apache#6475 apache#6474 apache#6473 Author: Reynold Xin <[email protected]> Closes apache#6487 from rxin/whitespace-lint and squashes the following commits: b33d43d [Reynold Xin] [SPARK-7929] Turn whitespace checker on for more token types.
ckadner
pushed a commit
to ckadner/bahir_from_spark_8301fad
that referenced
this pull request
Jun 6, 2016
This is the last batch of changes to complete SPARK-7929. Previous related PRs: apache/spark#6480 apache/spark#6478 apache/spark#6477 apache/spark#6476 apache/spark#6475 apache/spark#6474 apache/spark#6473 Author: Reynold Xin <[email protected]> Closes #6487 from rxin/whitespace-lint and squashes the following commits: b33d43d [Reynold Xin] [SPARK-7929] Turn whitespace checker on for more token types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can enable a whitespace enforcement rule in the style checker to save code review time.